You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/03/25 21:13:58 UTC

[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #3436: Traffic router add https

mattjackson220 opened a new pull request #3436: Traffic router add https
URL: https://github.com/apache/trafficcontrol/pull/3436
 
 
   …TPS if available, updated tests and documentation
   
   ## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
   
   Fixes #2817  
   
   ## Which TC components are affected by this PR?
   
   - [ X] Documentation
   - [ ] Grove
   - [ ] Traffic Analytics
   - [ ] Traffic Monitor
   - [ X] Traffic Ops
   - [ ] Traffic Ops ORT
   - [ ] Traffic Portal
   - [ X] Traffic Router
   - [ ] Traffic Stats
   - [ ] Traffic Vault
   - [ ] Other _________
   
   ## What is the best way to verify this PR? Please include manual steps or automated tests. 
   ### (If no tests are part of this PR, please provide explanation as to why no tests are included.)
   Verify that CDN-in-a-box has secure.api.port defined in server.xml as 3443. Run CDN-in-a-box and verify the following:
   - Traffic Router port 3443 is accessible
   - https://{Traffic Router}:3443/crs/stats returns the same results as http://{Traffic Router}:3333/crs/stats
   - /opt/traffic_router/conf/keyStore.jks is created on the Traffic Router server
   - https://{Traffic Router}:3443 uses the certificate created at install
   - {Traffic Ops}/api/1.4/cdns/routing and {Traffic Portal}/api/1.4/cdns/routing return the same result and successfully access the Traffic Router API through port 3443
   
   Then remove the secure.api.port property from server.xml and verify:
   - Traffic Router port 3443 is not accessible
   - http://{Traffic Router}:3333/crs/stats returns the same results as before
   - {Traffic Ops}/api/1.4/cdns/routing and {Traffic Portal}/api/1.4/cdns/routing return the same result and successfully access the Traffic Router API through port 3333
   
   
   ## Check all that apply
   
   - [ X] This PR includes tests
   - [ X] This PR includes documentation updates
   - [ X] This PR includes an update to CHANGELOG.md
   - [ X] This PR includes all required license headers
   - [ ] This PR includes a database migration (ensure that migration sequence is correct)
   - [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
   
   <!--
       Licensed to the Apache Software Foundation (ASF) under one
       or more contributor license agreements.  See the NOTICE file
       distributed with this work for additional information
       regarding copyright ownership.  The ASF licenses this file
       to you under the Apache License, Version 2.0 (the
       "License"); you may not use this file except in compliance
       with the License.  You may obtain a copy of the License at
   
         http://www.apache.org/licenses/LICENSE-2.0
   
       Unless required by applicable law or agreed to in writing,
       software distributed under the License is distributed on an
       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
       KIND, either express or implied.  See the License for the
       specific language governing permissions and limitations
       under the License.
   -->
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services