You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/10/08 21:26:52 UTC
[GitHub] codecov-io edited a comment on issue #6004: check db extra and
metadata params preemptively
codecov-io edited a comment on issue #6004: check db extra and metadata params preemptively
URL: https://github.com/apache/incubator-superset/pull/6004#issuecomment-425597140
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=h1) Report
> Merging [#6004](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4868c00d6dff3c6a1f790a0da0abe854005498c1?src=pr&el=desc) will **increase** coverage by `14.33%`.
> The diff coverage is `69.23%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6004 +/- ##
===========================================
+ Coverage 63.48% 77.82% +14.33%
===========================================
Files 443 46 -397
Lines 23753 9424 -14329
Branches 2638 0 -2638
===========================================
- Hits 15080 7334 -7746
+ Misses 8660 2090 -6570
+ Partials 13 0 -13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.05% <100%> (-0.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.84% <66.66%> (+0.1%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.39% <0%> (-0.9%)` | :arrow_down: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `55.61% <0%> (-0.09%)` | :arrow_down: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `64.34% <0%> (ø)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `68% <0%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.04% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| ... and [398 more](https://codecov.io/gh/apache/incubator-superset/pull/6004/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=footer). Last update [4868c00...07b3e07](https://codecov.io/gh/apache/incubator-superset/pull/6004?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org