You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/07 14:26:17 UTC
[GitHub] [incubator-doris] caiconghui opened a new pull request, #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
caiconghui opened a new pull request, #9449:
URL: https://github.com/apache/incubator-doris/pull/9449
# Proposed changes
Issue Number: close #9441
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120222657
> > strongly recommended formatter the code first by running:
> > > sh build-support/clang-format.sh
> >
> >
> > The master branch has been formatted
>
> run it, but it seems not as expected
You need to use clang format v11, see http://doris.incubator.apache.org/zh-CN/developer-guide/cpp-format-code.html#%E7%8E%AF%E5%A2%83%E5%87%86%E5%A4%87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chenlinzhong commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120223602
> > strongly recommended formatter the code first by running:
> > > sh build-support/clang-format.sh
> >
> >
> > The master branch has been formatted
>
> run it, but it seems not as expected
what's error ? maybe clang-format version is too lower ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
caiconghui commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120222328
> strongly recommended formatter the code first by running:
>
> > sh build-support/clang-format.sh
>
> The master branch has been formatted
run it, but it seems not as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
caiconghui commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120220102
cc @chenlinzhong @yiguolei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui merged pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
caiconghui merged PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120332790
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chenlinzhong commented on pull request #9449: [Fix](schema_hash) Fix bug that introduced by removing schema_hash
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on PR #9449:
URL: https://github.com/apache/incubator-doris/pull/9449#issuecomment-1120221380
strongly recommended formatter the code first by running:
> sh build-support/clang-format.sh
The master branch has been formatted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org