You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/08 11:48:43 UTC

[GitHub] [ignite-3] sashapolo commented on a change in pull request #86: IGNITE-14476 Get rid of using storage implementation explicitly in ConfigurationRoot annotation

sashapolo commented on a change in pull request #86:
URL: https://github.com/apache/ignite-3/pull/86#discussion_r609608012



##########
File path: modules/configuration-annotation-processor/src/test/java/org/apache/ignite/configuration/notifications/ConfigurationListenerTest.java
##########
@@ -70,9 +71,11 @@
     public void before() {
         registry.registerRootKey(ParentConfiguration.KEY);
 
-        registry.registerStorage(new TestConfigurationStorage());
+        TestConfigurationStorage storage = new TestConfigurationStorage();
 
-        registry.startStorageConfigurations(TestConfigurationStorage.class);
+        registry.registerStorage(storage);

Review comment:
       why do `registerStorage` and `startStorageConfigurations` have to be two separate methods?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org