You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "mapleFU (via GitHub)" <gi...@apache.org> on 2023/06/14 17:31:04 UTC
[GitHub] [parquet-format] mapleFU opened a new pull request, #211: PARQUET-2222: Fix broken link for Plain Boolean
mapleFU opened a new pull request, #211:
URL: https://github.com/apache/parquet-format/pull/211
Make sure you have checked _all_ steps below.
### Jira
https://issues.apache.org/jira/browse/PARQUET-2222
### Commits
- [x] My commits all reference Jira issues in their subject lines.
### Documentation
Is already documented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] gszadovszky commented on pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #211:
URL: https://github.com/apache/parquet-format/pull/211#issuecomment-1592837245
@mapleFU, could you also fix this?
> We still have Data page v1 / Boolean values listed in the prepend length table of RLE which is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] mapleFU commented on pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #211:
URL: https://github.com/apache/parquet-format/pull/211#issuecomment-1591712882
@pitrou @gszadovszky @wgtmac
This patch fix the RLE link in PLAIN, and also fix all internal links. It can be seen in https://github.com/mapleFU/parquet-format/blob/parquet/fix-link-for-bitpack/Encodings.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] gszadovszky commented on a diff in pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on code in PR #211:
URL: https://github.com/apache/parquet-format/pull/211#discussion_r1230535466
##########
Encodings.md:
##########
@@ -61,7 +61,8 @@ followed by the values encoded using RLE/Bit packed described above (with the gi
Using the PLAIN_DICTIONARY enum value is deprecated in the Parquet 2.0 specification. Prefer using RLE_DICTIONARY
in a data page and PLAIN in a dictionary page for Parquet 2.0+ files.
-### <a name="RLE"></a>Run Length Encoding / Bit-Packing Hybrid (RLE = 3)
+<a name="RLE"></a>
Review Comment:
Is moving the anchor out of the header an actual fix or just formatting? Asking only because this is how all the rest of the headers are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] mapleFU commented on pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on PR #211:
URL: https://github.com/apache/parquet-format/pull/211#issuecomment-1593085219
@gszadovszky Personally I'd like to fix it in another patch, I'm drafting it currently, this patch just fix the anchor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] gszadovszky commented on pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky commented on PR #211:
URL: https://github.com/apache/parquet-format/pull/211#issuecomment-1593134169
> @gszadovszky Personally I'd like to fix it in another patch, I'm drafting it currently, this patch just fix the anchor.
@mapleFU, sounds good. Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] mapleFU commented on a diff in pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on code in PR #211:
URL: https://github.com/apache/parquet-format/pull/211#discussion_r1230680253
##########
Encodings.md:
##########
@@ -61,7 +61,8 @@ followed by the values encoded using RLE/Bit packed described above (with the gi
Using the PLAIN_DICTIONARY enum value is deprecated in the Parquet 2.0 specification. Prefer using RLE_DICTIONARY
in a data page and PLAIN in a dictionary page for Parquet 2.0+ files.
-### <a name="RLE"></a>Run Length Encoding / Bit-Packing Hybrid (RLE = 3)
+<a name="RLE"></a>
Review Comment:
It's just a fixing for heading anchor in current format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou merged pull request #211: PARQUET-2222: Fix broken link for Plain Boolean
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou merged PR #211:
URL: https://github.com/apache/parquet-format/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org