You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/12/09 20:50:46 UTC
[PR] Fixu using latest constraints in sdist package tests [airflow]
potiuk opened a new pull request, #36146:
URL: https://github.com/apache/airflow/pull/36146
Follow-up after #36143 - I realized sdist package tests (only run in canary builds) will have the same problem as wheel installation.
I moved it closer in the workflow to the wheel installation to make it easier to remember to change it too.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixu using latest constraints in sdist package tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36146:
URL: https://github.com/apache/airflow/pull/36146#discussion_r1421569175
##########
.github/workflows/ci.yml:
##########
@@ -796,6 +796,69 @@ jobs:
breeze release-management prepare-provider-packages --skip-tag-check
--package-format wheel ${{ needs.build-info.outputs.affected-providers-list-as-string }}
+ prepare-install-provider-packages-sdist:
+ timeout-minutes: 80
+ name: "Provider packages sdist (install)"
+ runs-on: ${{fromJSON(needs.build-info.outputs.runs-on)}}
+ needs: [build-info, wait-for-ci-images]
+ env:
+ RUNS_ON: "${{needs.build-info.outputs.runs-on}}"
+ PYTHON_MAJOR_MINOR_VERSION: "${{needs.build-info.outputs.default-python-version}}"
+ USE_AIRFLOW_VERSION: "sdist"
+ if: >
+ needs.build-info.outputs.canary-run == 'true' &&
+ needs.build-info.outputs.skip-provider-tests != 'true'
+ steps:
+ - name: Cleanup repo
+ run: docker run -v "${GITHUB_WORKSPACE}:/workspace" -u 0:0 bash -c "rm -rf /workspace/*"
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+ uses: actions/checkout@v4
+ with:
+ persist-credentials: false
+ - name: >
+ Prepare breeze & CI image: ${{needs.build-info.outputs.default-python-version}}:${{env.IMAGE_TAG}}
+ uses: ./.github/actions/prepare_breeze_and_image
+ - name: "Cleanup dist files"
+ run: rm -fv ./dist/*
+ - name: "Prepare provider packages: sdist"
+ run: >
+ breeze release-management prepare-provider-packages
+ --version-suffix-for-pypi dev0 --package-format sdist
+ ${{ needs.build-info.outputs.affected-providers-list-as-string }}
+ - name: "Prepare airflow package: sdist"
+ run: >
+ breeze release-management prepare-airflow-package
+ --version-suffix-for-pypi dev0 --package-format sdist
+ - name: "Verify sdist packages with twine"
+ run: pipx install twine --force && twine check dist/*.tar.gz
+ - name: "Generate source constraints from CI image"
+ shell: bash
+ run: >
+ breeze release-management generate-constraints
+ --airflow-constraints-mode constraints-source-providers
+ - name: "Install all provider packages and airflow via sdist files"
+ run: >
+ breeze release-management install-provider-packages
+ --use-packages-from-dist
+ --package-format sdist
+ --use-airflow-version sdist
+ --airflow-constraints-reference default
+ --providers-constraints-location
+ /files/constraints-${{env.PYTHON_MAJOR_MINOR_VERSION}}/constraints-source-providers-${{env.PYTHON_MAJOR_MINOR_VERSION}}.txt
+ --run-in-parallel
+ if: needs.build-info.outputs.affected-providers-list-as-string == ''
+ - name: "Install affected provider packages and airflow via sdist files"
+ run: >
+ breeze release-management install-provider-packages
+ --use-packages-from-dist
+ --package-format sdist
+ --use-airflow-version sdist
+ --airflow-constraints-reference default
+ --providers-constraints-location
+ /files/constraints-${{env.PYTHON_MAJOR_MINOR_VERSION}}/constraints-source-providers-${{env.PYTHON_MAJOR_MINOR_VERSION}}.txt
Review Comment:
This is what really changed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix using latest constraints in sdist package tests [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36146:
URL: https://github.com/apache/airflow/pull/36146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org