[GitHub] piiswrong commented on a change in pull request #9119: fix random generator: do not gen seed each time

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #9119: fix random generator: do not gen seed each time
URL: https://github.com/apache/incubator-mxnet/pull/9119#discussion_r157559062
 
 

 ##########
 File path: src/common/random_generator.cc
 ##########
 @@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * Copyright (c) 2017 by Contributors
+ * \file random_generator.cc
+ * \brief cpu implements for random number generator.
+ */
+
+#include "./random_generator.h"
+
+namespace mxnet {
+namespace common {
+namespace random {
+
+template<>
+void RandGeneratorSeed<cpu, float>(Stream<cpu> *s,
+                                   RandGenerator<cpu, float> *gen,
+                                   uint32_t seed) {
+  gen->Seed(seed, 0);
+}
+
+template<>
+RandGenerator<cpu, float> *NewRandGenerator<cpu, float>() {
 
 Review comment:
   return an value so you don't need DeleteRandGenerator

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services