[GitHub] zachgk commented on a change in pull request #13189: [WIP] Fix scaladoc build errors

[GitBox <gi...@apache.org>]

zachgk commented on a change in pull request #13189: [WIP] Fix scaladoc build errors
URL: https://github.com/apache/incubator-mxnet/pull/13189#discussion_r232413996
 
 

 ##########
 File path: docs/mxdoc.py
 ##########
 @@ -109,7 +109,13 @@ def build_scala_docs(app):
     """build scala doc and then move the outdir"""
     scala_path = app.builder.srcdir + '/../scala-package'
     # scaldoc fails on some apis, so exit 0 to pass the check
-    _run_cmd('cd ' + scala_path + '; scaladoc `find . -type f -name "*.scala" | egrep \"\/core|\/infer\" | egrep -v \"Suite\"`; exit 0')
+    scala_doc_sources = 'find . -type f -name "*.scala" | egrep \"\.\/core|\.\/infer\" | egrep -v \"Suite\"'
+    scala_doc_classpath = ':'.join([
+        '`find native -name "*.jar" | grep "target/lib/" | tr "\n" ":" `',
+        '`find macros -name "*-SNAPSHOT.jar" | tr "\n" ":" `'
 
 Review comment:
   We only build the scaladocs for the core and infer modules. So, I am treating the macros build as a dependency (which is required to avoid some missing dependency errors). The other option is that we also build docs for the macros as well, but I think it is better to hide them since it is not really for the users

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services