You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/04 16:28:57 UTC

[GitHub] [beam] lukecwik commented on a diff in pull request #22373: remove the pulsar admin from pulsar connector

lukecwik commented on code in PR #22373:
URL: https://github.com/apache/beam/pull/22373#discussion_r938008308


##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarIO.java:
##########
@@ -87,10 +83,6 @@ abstract Builder setExtractOutputTimestampFn(
       abstract Read build();
     }
 
-    public Read withAdminUrl(String url) {

Review Comment:
   +1 for deprecating the APIs saying that they are now unused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org