[GitHub] drcrallen commented on a change in pull request #6864: add 'init' lifecycle stage for finer control over startup and shutdown

[GitBox <gi...@apache.org>]

drcrallen commented on a change in pull request #6864: add 'init' lifecycle stage for finer control over startup and shutdown
URL: https://github.com/apache/incubator-druid/pull/6864#discussion_r248126740
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/guice/LifecycleModule.java
 ##########
 @@ -37,6 +37,7 @@
  */
 public class LifecycleModule implements Module
 {
+  private final LifecycleScope initScope = new LifecycleScope(Lifecycle.Stage.INIT);
 
 Review comment:
   Can you add a doc somewhere that mentions things in this lifecycle should not log anything. So that means things should expect to fail silently and be fine, or might need to exit the whole jvm if there is a problem. But logging or warning do not fit into this lifecycle

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org