You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2022/04/19 00:37:40 UTC
[datasketches-java] branch RemoveExtraEmptyLines created (now fa70f52e)
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a change to branch RemoveExtraEmptyLines
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
at fa70f52e This does not affect any code, This is a cosmetic fix to remove extra blank lines. I did find a couple of Javadoc spelling errors.
This branch includes the following new commits:
new fa70f52e This does not affect any code, This is a cosmetic fix to remove extra blank lines. I did find a couple of Javadoc spelling errors.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[datasketches-java] 01/01: This does not affect any code, This is a cosmetic fix to remove extra blank lines. I did find a couple of Javadoc spelling errors.
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch RemoveExtraEmptyLines
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit fa70f52e7b7b674fdf2f9f3d96ccc1939b20b73e
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Mon Apr 18 17:36:12 2022 -0700
This does not affect any code, This is a cosmetic fix to remove extra
blank lines. I did find a couple of Javadoc spelling errors.
---
.asf.yaml | 3 +--
src/main/java/org/apache/datasketches/BinarySearch.java | 1 -
src/main/java/org/apache/datasketches/InequalitySearch.java | 2 --
src/main/java/org/apache/datasketches/SetOperationCornerCases.java | 1 -
src/main/java/org/apache/datasketches/Util.java | 1 -
.../java/org/apache/datasketches/cpc/CompressionCharacterization.java | 1 -
src/main/java/org/apache/datasketches/cpc/CpcCompression.java | 1 -
src/main/java/org/apache/datasketches/cpc/CpcSketch.java | 1 -
src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java | 1 -
src/main/java/org/apache/datasketches/cpc/StreamingValidation.java | 1 -
src/main/java/org/apache/datasketches/hash/MurmurHash3.java | 2 --
src/main/java/org/apache/datasketches/hll/BaseHllSketch.java | 2 --
.../java/org/apache/datasketches/hll/CompositeInterpolationXTable.java | 1 -
src/main/java/org/apache/datasketches/hll/CurMode.java | 1 -
src/main/java/org/apache/datasketches/hll/Hll6Array.java | 3 ---
src/main/java/org/apache/datasketches/hll/HllArray.java | 1 -
src/main/java/org/apache/datasketches/hll/HllSketch.java | 2 --
.../org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java | 1 -
src/main/java/org/apache/datasketches/quantiles/DoublesPmfCdfImpl.java | 1 -
src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java | 1 -
src/main/java/org/apache/datasketches/quantiles/ItemsMergeImpl.java | 1 -
src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java | 1 -
src/main/java/org/apache/datasketches/quantiles/PreambleUtil.java | 1 -
src/main/java/org/apache/datasketches/req/ReqSerDe.java | 3 +--
src/main/java/org/apache/datasketches/req/ReqSketch.java | 1 -
.../java/org/apache/datasketches/sampling/ReservoirItemsUnion.java | 1 -
.../java/org/apache/datasketches/sampling/ReservoirLongsUnion.java | 1 -
src/main/java/org/apache/datasketches/sampling/SamplingUtil.java | 1 -
src/main/java/org/apache/datasketches/theta/AnotBimpl.java | 1 -
.../datasketches/theta/ConcurrentBackgroundThetaPropagation.java | 2 --
.../java/org/apache/datasketches/theta/ConcurrentHeapThetaBuffer.java | 1 -
.../java/org/apache/datasketches/theta/DirectQuickSelectSketchR.java | 3 ---
src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java | 3 ---
src/main/java/org/apache/datasketches/theta/SingleItemSketch.java | 1 -
src/main/java/org/apache/datasketches/theta/Sketch.java | 1 -
src/main/java/org/apache/datasketches/theta/Union.java | 2 --
src/main/java/org/apache/datasketches/tuple/Sketch.java | 1 -
src/main/java/org/apache/datasketches/tuple/Util.java | 2 --
.../datasketches/tuple/arrayofdoubles/ArrayOfDoublesAnotBImpl.java | 2 --
.../apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUnion.java | 1 -
.../tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java | 1 -
41 files changed, 2 insertions(+), 57 deletions(-)
diff --git a/.asf.yaml b/.asf.yaml
index c1311dad..bb7c0ff1 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -1,4 +1,3 @@
github:
homepage: https://datasketches.apache.org
- collaborators:
- - will-lauer
\ No newline at end of file
+ collaborators:
\ No newline at end of file
diff --git a/src/main/java/org/apache/datasketches/BinarySearch.java b/src/main/java/org/apache/datasketches/BinarySearch.java
index b6901fe9..11f19ef9 100644
--- a/src/main/java/org/apache/datasketches/BinarySearch.java
+++ b/src/main/java/org/apache/datasketches/BinarySearch.java
@@ -26,7 +26,6 @@ package org.apache.datasketches;
*/
public final class BinarySearch {
-
/**
* Binary Search for the index of the exact float value in the given search range.
* If -1 is returned there are no values in the search range that equals the given value.
diff --git a/src/main/java/org/apache/datasketches/InequalitySearch.java b/src/main/java/org/apache/datasketches/InequalitySearch.java
index 8764b1a7..bb2c3c22 100644
--- a/src/main/java/org/apache/datasketches/InequalitySearch.java
+++ b/src/main/java/org/apache/datasketches/InequalitySearch.java
@@ -524,7 +524,6 @@ public enum InequalitySearch {
*/
abstract int compare(long[] arr, int a, int b, long v);
-
/**
* If the compare operation returns 0, which means "found", this returns the index of the
* found value that satisfies the selected criteria.
@@ -558,7 +557,6 @@ public enum InequalitySearch {
*/
abstract int getIndex(long[] arr, int a, int b, long v);
-
/**
* Called to resolve what to do if not found. In the search algorithm this occurs when the
* <i>lo</i> and <i>hi</i> indices become inverted at the ends of the array.
diff --git a/src/main/java/org/apache/datasketches/SetOperationCornerCases.java b/src/main/java/org/apache/datasketches/SetOperationCornerCases.java
index c8374a78..8dccd24c 100644
--- a/src/main/java/org/apache/datasketches/SetOperationCornerCases.java
+++ b/src/main/java/org/apache/datasketches/SetOperationCornerCases.java
@@ -100,7 +100,6 @@ public class SetOperationCornerCases {
}
}
-
public enum CornerCase {
Empty_Empty(055, "A{ 1.0, 0, T} ; B{ 1.0, 0, T}",
IntersectAction.EMPTY_1_0_T, AnotbAction.EMPTY_1_0_T, UnionAction.EMPTY_1_0_T),
diff --git a/src/main/java/org/apache/datasketches/Util.java b/src/main/java/org/apache/datasketches/Util.java
index f0fee42c..f4b6c47e 100644
--- a/src/main/java/org/apache/datasketches/Util.java
+++ b/src/main/java/org/apache/datasketches/Util.java
@@ -668,7 +668,6 @@ public final class Util {
return prev;
}
-
/**
* The log base 2 of the value
* @param value the given value
diff --git a/src/main/java/org/apache/datasketches/cpc/CompressionCharacterization.java b/src/main/java/org/apache/datasketches/cpc/CompressionCharacterization.java
index dd617444..3763c442 100644
--- a/src/main/java/org/apache/datasketches/cpc/CompressionCharacterization.java
+++ b/src/main/java/org/apache/datasketches/cpc/CompressionCharacterization.java
@@ -67,7 +67,6 @@ public class CompressionCharacterization {
private CompressedState[] compressedStates2;
private CpcSketch[] unCompressedSketches;
-
public CompressionCharacterization(
final int lgMinK,
final int lgMaxK,
diff --git a/src/main/java/org/apache/datasketches/cpc/CpcCompression.java b/src/main/java/org/apache/datasketches/cpc/CpcCompression.java
index f173ab1b..f811d8db 100644
--- a/src/main/java/org/apache/datasketches/cpc/CpcCompression.java
+++ b/src/main/java/org/apache/datasketches/cpc/CpcCompression.java
@@ -832,7 +832,6 @@ final class CpcCompression {
}
}
-
private static long divideBy32RoundingUp(final long x) {
final long tmp = x >>> 5;
return ((tmp << 5) == x) ? tmp : tmp + 1;
diff --git a/src/main/java/org/apache/datasketches/cpc/CpcSketch.java b/src/main/java/org/apache/datasketches/cpc/CpcSketch.java
index 7b324552..162a9c45 100644
--- a/src/main/java/org/apache/datasketches/cpc/CpcSketch.java
+++ b/src/main/java/org/apache/datasketches/cpc/CpcSketch.java
@@ -649,7 +649,6 @@ public final class CpcSketch {
}
}
-
//also used in test
static CpcSketch uncompress(final CompressedState source, final long seed) {
checkSeedHashes(computeSeedHash(seed), source.seedHash);
diff --git a/src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java b/src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java
index 022dc883..d5d3e32b 100644
--- a/src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java
+++ b/src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java
@@ -134,7 +134,6 @@ public class QuickMergingValidation {
updA_mS, updB_mS, mrgA_mS, mrgB_mS, rslt_mS);
}
-
private void printf(final String format, final Object ... args) {
if (printStream != null) { printStream.printf(format, args); }
if (printWriter != null) { printWriter.printf(format, args); }
diff --git a/src/main/java/org/apache/datasketches/cpc/StreamingValidation.java b/src/main/java/org/apache/datasketches/cpc/StreamingValidation.java
index 6e9c9ef3..0cd8c48c 100644
--- a/src/main/java/org/apache/datasketches/cpc/StreamingValidation.java
+++ b/src/main/java/org/apache/datasketches/cpc/StreamingValidation.java
@@ -50,7 +50,6 @@ public class StreamingValidation {
private PrintStream printStream;
private PrintWriter printWriter;
-
//sketches
private CpcSketch sketch = null;
private BitMatrix matrix = null;
diff --git a/src/main/java/org/apache/datasketches/hash/MurmurHash3.java b/src/main/java/org/apache/datasketches/hash/MurmurHash3.java
index 1e5c3cad..eb9756e5 100644
--- a/src/main/java/org/apache/datasketches/hash/MurmurHash3.java
+++ b/src/main/java/org/apache/datasketches/hash/MurmurHash3.java
@@ -190,7 +190,6 @@ public final class MurmurHash3 implements Serializable {
return hashState.finalMix128(k1, k2, lengthInts << 2); //convert to bytes
}
-
//--Hash of char[]-------------------------------------------------------
/**
* Hash the given char[] array.
@@ -219,7 +218,6 @@ public final class MurmurHash3 implements Serializable {
Util.checkBounds(offsetChars, lengthChars, arrLen);
final HashState hashState = new HashState(seed, seed);
-
// Number of full 128-bit blocks of 8 chars.
// Possible exclusion of a remainder of up to 7 chars.
final int nblocks = lengthChars >>> 3; //chars / 8
diff --git a/src/main/java/org/apache/datasketches/hll/BaseHllSketch.java b/src/main/java/org/apache/datasketches/hll/BaseHllSketch.java
index 324bf9f8..c53a8701 100644
--- a/src/main/java/org/apache/datasketches/hll/BaseHllSketch.java
+++ b/src/main/java/org/apache/datasketches/hll/BaseHllSketch.java
@@ -400,6 +400,4 @@ abstract class BaseHllSketch {
return (value << KEY_BITS_26) | addr26;
}
-
-
}
diff --git a/src/main/java/org/apache/datasketches/hll/CompositeInterpolationXTable.java b/src/main/java/org/apache/datasketches/hll/CompositeInterpolationXTable.java
index 119f1c75..030a3cf9 100644
--- a/src/main/java/org/apache/datasketches/hll/CompositeInterpolationXTable.java
+++ b/src/main/java/org/apache/datasketches/hll/CompositeInterpolationXTable.java
@@ -32,7 +32,6 @@ final class CompositeInterpolationXTable {
static final int[] yStrides =
{1, 2, 3, 5, 10, 20, 40, 80, 160, 320, 640, 1280, 2560, 5120, 10240, 20480, 40960, 81920 };
-
static final double xArrs[][] = {
// log K = 4
{
diff --git a/src/main/java/org/apache/datasketches/hll/CurMode.java b/src/main/java/org/apache/datasketches/hll/CurMode.java
index 9202a8e7..a31266ce 100644
--- a/src/main/java/org/apache/datasketches/hll/CurMode.java
+++ b/src/main/java/org/apache/datasketches/hll/CurMode.java
@@ -38,5 +38,4 @@ enum CurMode { LIST, SET, HLL; //do not change the order.
return values[ordinal];
}
-
}
diff --git a/src/main/java/org/apache/datasketches/hll/Hll6Array.java b/src/main/java/org/apache/datasketches/hll/Hll6Array.java
index 81b6145a..fd6b1532 100644
--- a/src/main/java/org/apache/datasketches/hll/Hll6Array.java
+++ b/src/main/java/org/apache/datasketches/hll/Hll6Array.java
@@ -34,7 +34,6 @@ import org.apache.datasketches.memory.Memory;
*/
class Hll6Array extends HllArray {
-
/**
* Standard constructor for new instance
* @param lgConfigK the configured Lg K
@@ -134,8 +133,6 @@ class Hll6Array extends HllArray {
return (byte) ((getShortLE(arr, byteIdx) >>> shift) & 0X3F);
}
-
-
//ITERATOR
private final class HeapHll6Iterator extends HllPairIterator {
diff --git a/src/main/java/org/apache/datasketches/hll/HllArray.java b/src/main/java/org/apache/datasketches/hll/HllArray.java
index 6bc2f8f7..63ab6b1f 100644
--- a/src/main/java/org/apache/datasketches/hll/HllArray.java
+++ b/src/main/java/org/apache/datasketches/hll/HllArray.java
@@ -253,7 +253,6 @@ abstract class HllArray extends AbstractHllArray {
return ToByteArrayImpl.toHllByteArray(this, false);
}
-
//used by heapify by all Heap HLL
static final void extractCommonHll(final Memory srcMem, final HllArray hllArray) {
hllArray.putOutOfOrder(extractOooFlag(srcMem));
diff --git a/src/main/java/org/apache/datasketches/hll/HllSketch.java b/src/main/java/org/apache/datasketches/hll/HllSketch.java
index 6d9d3072..e401c1e2 100644
--- a/src/main/java/org/apache/datasketches/hll/HllSketch.java
+++ b/src/main/java/org/apache/datasketches/hll/HllSketch.java
@@ -269,8 +269,6 @@ public class HllSketch extends BaseHllSketch {
return directSketch;
}
-
-
/**
* Return a copy of this sketch onto the Java heap.
* @return a copy of this sketch onto the Java heap.
diff --git a/src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java b/src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java
index d61a54d8..3dbe93db 100644
--- a/src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java
+++ b/src/main/java/org/apache/datasketches/quantiles/DirectUpdateDoublesSketch.java
@@ -56,7 +56,6 @@ import org.apache.datasketches.memory.WritableMemory;
final class DirectUpdateDoublesSketch extends DirectUpdateDoublesSketchR {
MemoryRequestServer memReqSvr = null;
-
private DirectUpdateDoublesSketch(final int k) {
super(k); //Checks k
}
diff --git a/src/main/java/org/apache/datasketches/quantiles/DoublesPmfCdfImpl.java b/src/main/java/org/apache/datasketches/quantiles/DoublesPmfCdfImpl.java
index d151871a..29134473 100644
--- a/src/main/java/org/apache/datasketches/quantiles/DoublesPmfCdfImpl.java
+++ b/src/main/java/org/apache/datasketches/quantiles/DoublesPmfCdfImpl.java
@@ -114,7 +114,6 @@ class DoublesPmfCdfImpl {
}
}
-
/**
* This one does a linear time simultaneous walk of the samples and splitPoints. Because this
* internal procedure is called multiple times, we require the caller to ensure these 3 properties:
diff --git a/src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java b/src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java
index 9553457d..117e30e6 100644
--- a/src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java
+++ b/src/main/java/org/apache/datasketches/quantiles/DoublesUnion.java
@@ -106,7 +106,6 @@ public abstract class DoublesUnion {
*/
public abstract int getEffectiveK();
-
/**
* Iterative union operation, which means this method can be repeatedly called.
* Merges the given sketch into this union object.
diff --git a/src/main/java/org/apache/datasketches/quantiles/ItemsMergeImpl.java b/src/main/java/org/apache/datasketches/quantiles/ItemsMergeImpl.java
index 2bf45644..48c84c96 100644
--- a/src/main/java/org/apache/datasketches/quantiles/ItemsMergeImpl.java
+++ b/src/main/java/org/apache/datasketches/quantiles/ItemsMergeImpl.java
@@ -306,7 +306,6 @@ final class ItemsMergeImpl {
arrStart1, comparator); // which will be arrStart3
}
-
/**
* Performs two merges in tandem. One of them provides the sort keys
* while the other one passively undergoes the same data motion.
diff --git a/src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java b/src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java
index 6d384b70..6847a019 100644
--- a/src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java
+++ b/src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java
@@ -612,7 +612,6 @@ public final class ItemsSketch<T> {
return PreambleUtil.toString(mem, false);
}
-
/**
* From an existing sketch, this creates a new sketch that can have a smaller value of K.
* The original sketch is not modified.
diff --git a/src/main/java/org/apache/datasketches/quantiles/PreambleUtil.java b/src/main/java/org/apache/datasketches/quantiles/PreambleUtil.java
index 2b3f5395..47b22c47 100644
--- a/src/main/java/org/apache/datasketches/quantiles/PreambleUtil.java
+++ b/src/main/java/org/apache/datasketches/quantiles/PreambleUtil.java
@@ -105,7 +105,6 @@ final class PreambleUtil {
// ###### TO HERE.
-
// STRINGS
/**
* Returns a human readable string summary of the internal state of the given byte array.
diff --git a/src/main/java/org/apache/datasketches/req/ReqSerDe.java b/src/main/java/org/apache/datasketches/req/ReqSerDe.java
index 5164852f..e7a804b5 100644
--- a/src/main/java/org/apache/datasketches/req/ReqSerDe.java
+++ b/src/main/java/org/apache/datasketches/req/ReqSerDe.java
@@ -31,9 +31,8 @@ import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableBuffer;
import org.apache.datasketches.memory.WritableMemory;
-
/**
- * This class handles serialization and desserialization.
+ * This class handles serialization and deserialization.
*
* <p>ReqSketch SERIALIZATION FORMAT.</p>
*
diff --git a/src/main/java/org/apache/datasketches/req/ReqSketch.java b/src/main/java/org/apache/datasketches/req/ReqSketch.java
index 707f891e..6b080831 100644
--- a/src/main/java/org/apache/datasketches/req/ReqSketch.java
+++ b/src/main/java/org/apache/datasketches/req/ReqSketch.java
@@ -26,7 +26,6 @@ import java.util.List;
import org.apache.datasketches.SketchesArgumentException;
import org.apache.datasketches.memory.Memory;
-
/**
* This Relative Error Quantiles Sketch is the Java implementation based on the paper
* "Relative Error Streaming Quantiles", https://arxiv.org/abs/2004.01668, and loosely derived from
diff --git a/src/main/java/org/apache/datasketches/sampling/ReservoirItemsUnion.java b/src/main/java/org/apache/datasketches/sampling/ReservoirItemsUnion.java
index 52b733b8..5c97b6c1 100644
--- a/src/main/java/org/apache/datasketches/sampling/ReservoirItemsUnion.java
+++ b/src/main/java/org/apache/datasketches/sampling/ReservoirItemsUnion.java
@@ -427,7 +427,6 @@ public final class ReservoirItemsUnion<T> {
} // end of inlined weight update
} // end of loop over source samples
-
// targetTotal was fractional but should now be an integer again. Could validate with low
// tolerance, but for now just round to check.
final long checkN = (long) Math.floor(0.5 + targetTotal);
diff --git a/src/main/java/org/apache/datasketches/sampling/ReservoirLongsUnion.java b/src/main/java/org/apache/datasketches/sampling/ReservoirLongsUnion.java
index afd0e998..1b5edb21 100644
--- a/src/main/java/org/apache/datasketches/sampling/ReservoirLongsUnion.java
+++ b/src/main/java/org/apache/datasketches/sampling/ReservoirLongsUnion.java
@@ -379,7 +379,6 @@ public final class ReservoirLongsUnion {
} // end of inlined weight update
} // end of loop over source samples
-
// targetTotal was fractional but should now be an integer again. Could validate with
// low tolerance, but for now just round to check.
final long checkN = (long) Math.floor(0.5 + targetTotal);
diff --git a/src/main/java/org/apache/datasketches/sampling/SamplingUtil.java b/src/main/java/org/apache/datasketches/sampling/SamplingUtil.java
index e43cce7a..13cdbc51 100644
--- a/src/main/java/org/apache/datasketches/sampling/SamplingUtil.java
+++ b/src/main/java/org/apache/datasketches/sampling/SamplingUtil.java
@@ -37,7 +37,6 @@ final class SamplingUtil {
*/
private static final double DEFAULT_KAPPA = 2.0;
-
private SamplingUtil() {}
/**
diff --git a/src/main/java/org/apache/datasketches/theta/AnotBimpl.java b/src/main/java/org/apache/datasketches/theta/AnotBimpl.java
index ae4c69e4..77e290e3 100644
--- a/src/main/java/org/apache/datasketches/theta/AnotBimpl.java
+++ b/src/main/java/org/apache/datasketches/theta/AnotBimpl.java
@@ -135,7 +135,6 @@ final class AnotBimpl extends AnotB {
final long[] hashArrA = getHashArrA(skA);
final int countA = hashArrA.length;
-
//process B
final long[] hashArrOut = getResultHashArr(minThetaLong, countA, hashArrA, skB); //out is clone
final int countOut = hashArrOut.length;
diff --git a/src/main/java/org/apache/datasketches/theta/ConcurrentBackgroundThetaPropagation.java b/src/main/java/org/apache/datasketches/theta/ConcurrentBackgroundThetaPropagation.java
index f9201a3d..9ae9c9c5 100644
--- a/src/main/java/org/apache/datasketches/theta/ConcurrentBackgroundThetaPropagation.java
+++ b/src/main/java/org/apache/datasketches/theta/ConcurrentBackgroundThetaPropagation.java
@@ -39,7 +39,6 @@ class ConcurrentBackgroundThetaPropagation implements Runnable {
// local buffer. Updated when the propagation completes.
private final AtomicBoolean localPropagationInProgress;
-
// Sketch to be propagated to shared sketch. Can be null if only a single hash is propagated
private final Sketch sketchIn;
@@ -47,7 +46,6 @@ class ConcurrentBackgroundThetaPropagation implements Runnable {
// if the data is propagated through a sketch.
private final long singleHash;
-
// The propagation epoch. The data can be propagated only within the context of this epoch.
// The data should not be propagated if this epoch is not equal to the
// shared sketch epoch.
diff --git a/src/main/java/org/apache/datasketches/theta/ConcurrentHeapThetaBuffer.java b/src/main/java/org/apache/datasketches/theta/ConcurrentHeapThetaBuffer.java
index e397ecc8..0095e8e4 100644
--- a/src/main/java/org/apache/datasketches/theta/ConcurrentHeapThetaBuffer.java
+++ b/src/main/java/org/apache/datasketches/theta/ConcurrentHeapThetaBuffer.java
@@ -220,5 +220,4 @@ final class ConcurrentHeapThetaBuffer extends HeapQuickSelectSketch {
return state;
}
-
}
diff --git a/src/main/java/org/apache/datasketches/theta/DirectQuickSelectSketchR.java b/src/main/java/org/apache/datasketches/theta/DirectQuickSelectSketchR.java
index 7e99cd4b..580a5b29 100644
--- a/src/main/java/org/apache/datasketches/theta/DirectQuickSelectSketchR.java
+++ b/src/main/java/org/apache/datasketches/theta/DirectQuickSelectSketchR.java
@@ -89,7 +89,6 @@ class DirectQuickSelectSketchR extends UpdateSketch {
return dqssr;
}
-
/**
* Fast-wrap a sketch around the given source Memory containing sketch data that originated from
* this sketch. This does NO validity checking of the given Memory.
@@ -239,8 +238,6 @@ class DirectQuickSelectSketchR extends UpdateSketch {
return wmem_;
}
-
-
@Override
short getSeedHash() {
return (short) PreambleUtil.extractSeedHash(wmem_);
diff --git a/src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java b/src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java
index b0fe67e7..6ab67528 100644
--- a/src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java
+++ b/src/main/java/org/apache/datasketches/theta/SetOperationBuilder.java
@@ -104,8 +104,6 @@ public class SetOperationBuilder {
return bLgNomLongs;
}
-
-
/**
* Sets the long seed value that is require by the hashing function.
* @param seed <a href="{@docRoot}/resources/dictionary.html#seed">See seed</a>
@@ -286,7 +284,6 @@ public class SetOperationBuilder {
return (AnotB) build(Family.A_NOT_B);
}
-
@Override
public String toString() {
final StringBuilder sb = new StringBuilder();
diff --git a/src/main/java/org/apache/datasketches/theta/SingleItemSketch.java b/src/main/java/org/apache/datasketches/theta/SingleItemSketch.java
index 6b2b7afc..1ab27b3a 100644
--- a/src/main/java/org/apache/datasketches/theta/SingleItemSketch.java
+++ b/src/main/java/org/apache/datasketches/theta/SingleItemSketch.java
@@ -90,7 +90,6 @@ final class SingleItemSketch extends CompactSketch {
throw new SketchesArgumentException("Input Memory is not a SingleItemSketch.");
}
-
@Override
public CompactSketch compact(final boolean dstOrdered, final WritableMemory dstMem) {
if (dstMem == null) { return this; }
diff --git a/src/main/java/org/apache/datasketches/theta/Sketch.java b/src/main/java/org/apache/datasketches/theta/Sketch.java
index ec9c1fed..76199d1c 100644
--- a/src/main/java/org/apache/datasketches/theta/Sketch.java
+++ b/src/main/java/org/apache/datasketches/theta/Sketch.java
@@ -47,7 +47,6 @@ import org.apache.datasketches.memory.WritableMemory;
public abstract class Sketch {
static final int DEFAULT_LG_RESIZE_FACTOR = 3; //Unique to Heap
-
Sketch() {}
//public static factory constructor-type methods
diff --git a/src/main/java/org/apache/datasketches/theta/Union.java b/src/main/java/org/apache/datasketches/theta/Union.java
index ad93f543..6756af6a 100644
--- a/src/main/java/org/apache/datasketches/theta/Union.java
+++ b/src/main/java/org/apache/datasketches/theta/Union.java
@@ -31,7 +31,6 @@ import org.apache.datasketches.memory.WritableMemory;
*/
public abstract class Union extends SetOperation {
-
/**
* Returns the number of storage bytes required for this union in its current state.
*
@@ -113,7 +112,6 @@ public abstract class Union extends SetOperation {
public abstract CompactSketch union(Sketch sketchA, Sketch sketchB, boolean dstOrdered,
WritableMemory dstMem);
-
/**
* Perform a Union operation with <i>this</i> union and the given on-heap sketch of the Theta Family.
* This method is not valid for the older SetSketch, which was prior to Open Source (August, 2015).
diff --git a/src/main/java/org/apache/datasketches/tuple/Sketch.java b/src/main/java/org/apache/datasketches/tuple/Sketch.java
index ef11a0f4..1e8c347b 100644
--- a/src/main/java/org/apache/datasketches/tuple/Sketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/Sketch.java
@@ -23,7 +23,6 @@ import static org.apache.datasketches.Util.LS;
import org.apache.datasketches.BinomialBoundsN;
-
/**
* This is an equivalent to org.apache.datasketches.theta.Sketch with
* addition of a user-defined Summary object associated with every unique entry
diff --git a/src/main/java/org/apache/datasketches/tuple/Util.java b/src/main/java/org/apache/datasketches/tuple/Util.java
index 58a5afd1..a1834eab 100644
--- a/src/main/java/org/apache/datasketches/tuple/Util.java
+++ b/src/main/java/org/apache/datasketches/tuple/Util.java
@@ -31,7 +31,6 @@ import java.lang.reflect.Array;
import org.apache.datasketches.SketchesArgumentException;
-
/**
* Common utility functions for Tuples
*/
@@ -162,5 +161,4 @@ public final class Util {
return tmpSummaryArr;
}
-
}
diff --git a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesAnotBImpl.java b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesAnotBImpl.java
index 3f8c74cb..a64116b3 100644
--- a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesAnotBImpl.java
+++ b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesAnotBImpl.java
@@ -37,7 +37,6 @@ import org.apache.datasketches.SketchesArgumentException;
import org.apache.datasketches.memory.WritableMemory;
import org.apache.datasketches.tuple.Util;
-
/**
* Computes a set difference, A-AND-NOT-B, of two ArrayOfDoublesSketches.
*
@@ -193,7 +192,6 @@ public class ArrayOfDoublesAnotBImpl extends ArrayOfDoublesAnotB {
return daR;
}
-
private static class DataArrays {
long[] hashArr;
double[] valuesArr;
diff --git a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUnion.java b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUnion.java
index aaa54060..ee15c4bb 100644
--- a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUnion.java
+++ b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUnion.java
@@ -181,7 +181,6 @@ public abstract class ArrayOfDoublesUnion {
setUnionThetaLong(gadget_.getThetaLong());
}
-
// Layout of first 16 bytes:
// Long || Start Byte Adr:
// Adr:
diff --git a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
index 127090bd..f1a19bc1 100644
--- a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/HeapArrayOfDoublesQuickSelectSketch.java
@@ -34,7 +34,6 @@ import org.apache.datasketches.memory.WritableMemory;
import org.apache.datasketches.tuple.SerializerDeserializer;
import org.apache.datasketches.tuple.Util;
-
/**
* The on-heap implementation of the tuple QuickSelect sketch of type ArrayOfDoubles.
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org