You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/01/21 12:41:51 UTC

Review Request 30115: Add Repo Base URL Validation as well as "Skip".

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30115/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-9232
    https://issues.apache.org/jira/browse/AMBARI-9232


Repository: ambari


Description
-------

Add Repo Base URL Validation as well as "Skip".


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js e62d22787994ac4f13a8ff61105da7c3a91b651a 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 66b51df72358b15186976a371e00fa903704f559 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js f86a47f184c1c5d09bc591b95f6afc5b4a193fdd 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 83bd21a814cbb0236240d256e56f32b3d86f547e 
  ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html f0e3ef4539696bcf5d92544c726c8389a9af6069 
  ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/edit.html 30c3d2ddd665fb4729a704c46aa87ee33367372a 
  ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html PRE-CREATION 

Diff: https://reviews.apache.org/r/30115/diff/


Testing
-------

was tested manual


Thanks,

Andriy Babiichuk

Re: Review Request 30115: Add Repo Base URL Validation as well as "Skip".

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30115/#review68901
-----------------------------------------------------------

Ship it!


Ship It!

- Andrii Tkach


On Янв. 21, 2015, 11:41 д.п., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30115/
> -----------------------------------------------------------
> 
> (Updated Янв. 21, 2015, 11:41 д.п.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-9232
>     https://issues.apache.org/jira/browse/AMBARI-9232
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Repo Base URL Validation as well as "Skip".
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js e62d22787994ac4f13a8ff61105da7c3a91b651a 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js 66b51df72358b15186976a371e00fa903704f559 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/routes.js f86a47f184c1c5d09bc591b95f6afc5b4a193fdd 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 83bd21a814cbb0236240d256e56f32b3d86f547e 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/create.html f0e3ef4539696bcf5d92544c726c8389a9af6069 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/edit.html 30c3d2ddd665fb4729a704c46aa87ee33367372a 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30115/diff/
> 
> 
> Testing
> -------
> 
> was tested manual
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>