You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Akash Gupta <ak...@hotmail.com> on 2018/01/05 00:30:31 UTC
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
-----------------------------------------------------------
(Updated Jan. 5, 2018, 12:30 a.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description
-------
Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
- ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
- ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
- ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
Diffs (updated)
-----
src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
Diff: https://reviews.apache.org/r/63862/diff/4/
Changes: https://reviews.apache.org/r/63862/diff/3-4/
Testing
-------
Windows mesos-test:
[==========] 754 tests from 77 test cases ran. (270586 ms total)
[ PASSED ] 754 tests.
Windows DockerTest only:
[==========] 11 tests from 1 test case ran. (85617 ms total)
[ PASSED ] 11 tests.
Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==========] 12 tests from 1 test case ran. (12413 ms total)
[ PASSED ] 12 tests.
Thanks,
Akash Gupta
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195138
-----------------------------------------------------------
PASS: Mesos patch 63862 was successfully built and tested.
Reviews applied: `['63859', '63860', '63861', '63862']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
- Mesos Reviewbot Windows
On Jan. 6, 2018, 2:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2018, 2:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195528
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp
Lines 61-62 (patched)
<https://reviews.apache.org/r/63862/#comment275304>
Is it possible to run earlier/later versions of images?
i.e. If the base OS is 1710 (or later) can it still run this image? Or if the base OS is 1708 (or earlier) will the image definitely fail?
src/tests/containerizer/docker_tests.cpp
Lines 127 (patched)
<https://reviews.apache.org/r/63862/#comment274732>
Avoid using `CHECK` which can prematurely stop the test suite. Try `ASSERT_TRUE(future.ready());`.
src/tests/containerizer/docker_tests.cpp
Lines 155-163 (patched)
<https://reviews.apache.org/r/63862/#comment275311>
It doesn't really make a difference to the Linux tests whether they mount a file or directory. We might as well make them all mount a directory; and thereby remove this helper.
src/tests/containerizer/docker_tests.cpp
Lines 580-582 (original), 712-715 (patched)
<https://reviews.apache.org/r/63862/#comment275313>
Do you know if this will _never_ be supported?
In which case, we should get rid of the `_TEMP_DISABLED_ON_WINDOWS` and make the disabling more permanent.
- Joseph Wu
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198357
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63859, 63860, 63861, 63862]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/6/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 130-137 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line130>
> >
> > Looks like instead of this adhoc routine we should rather introduce a root prefix in stout.
I don't think we should introduce this abstraction into stout until it becomes the case that other code needs it too. Currently, this abstraction is needed solely to make the Docker tests compatible on both platforms. Let's avoid unnecessary stout bloat.
> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line139>
> >
> > Again, this is something we should likely do in a broader scope. Chances are, someone else in a different place will try to solve the same problem.
Same as above. At the point of someone else solving the same problem, then it would make sense to move the code into a more general purpose location and reuse it. But we shouldn't do it until then, because otherwise we're just guessing at future technical needs.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
-----------------------------------------------------------
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Jan. 10, 2018, 5:27 a.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line139>
> >
> > Again, this is something we should likely do in a broader scope. Chances are, someone else in a different place will try to solve the same problem.
>
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, then it would make sense to move the code into a more general purpose location and reuse it. But we shouldn't do it until then, because otherwise we're just guessing at future technical needs.
>
> Akash Gupta wrote:
> This is specific to Docker and only for test code that checks the container exit value, which is onlt used here. So, I don't think other places will ever use this.
I was talking with Alex, and while I don't think `stout` is necessarily the right place for this kind of code, there is potential clean up here:
```
src/tests/containerizer/docker_containerizer_tests.cpp
1288: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
1425: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
src/tests/containerizer/ns_tests.cpp
101: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
src/tests/containerizer/docker_tests.cpp
170: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
250: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
318: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, run);
449: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
528: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
574: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
623: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
844: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
918: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
src/tests/containerizer/capabilities_tests.cpp
98: AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
122: AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
151: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
3rdparty/libprocess/src/tests/reap_tests.cpp
98: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
172: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
3rdparty/libprocess/include/process/gtest.hpp
623:#define AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, duration) \
627:#define AWAIT_EXPECT_WEXITSTATUS_EQ(expected, actual) \
628: AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, Seconds(15))
664:#define AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, duration) \
668:#define AWAIT_EXPECT_WEXITSTATUS_NE(expected, actual) \
669: AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, Seconds(15))
3rdparty/libprocess/src/tests/subprocess_tests.cpp
72: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
249: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
264: AWAIT_EXPECT_WEXITSTATUS_EQ(1, s.get().status());
323: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
344: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
371: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
411: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
442: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
465: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
497: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
531: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
562: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
599: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
617: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
700: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
763: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
789: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
818: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
847: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
879: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
```
Especially the ones that do `128 + SIGKILL`; just WTF is that even doing? No one should have to go to [Stack Overflow](https://unix.stackexchange.com/a/99134) to understand what an assertion in a test is doing.
It may be reasonable to go to `include/process/gtest.hpp` and make this easier, with `AWAIT_EXPECT_EXIT_SIGKILL(status)` (and like `AWAIT_EXPECT_EXIT_SUCCESS(status)` for `== 0`).
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
-----------------------------------------------------------
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line139>
> >
> > Again, this is something we should likely do in a broader scope. Chances are, someone else in a different place will try to solve the same problem.
>
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, then it would make sense to move the code into a more general purpose location and reuse it. But we shouldn't do it until then, because otherwise we're just guessing at future technical needs.
>
> Akash Gupta wrote:
> This is specific to Docker and only for test code that checks the container exit value, which is onlt used here. So, I don't think other places will ever use this.
>
> Andrew Schwartzmeyer wrote:
> I was talking with Alex, and while I don't think `stout` is necessarily the right place for this kind of code, there is potential clean up here:
>
> ```
> src/tests/containerizer/docker_containerizer_tests.cpp
> 1288: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
> 1425: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, orphanRun);
>
> src/tests/containerizer/ns_tests.cpp
> 101: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
>
> src/tests/containerizer/docker_tests.cpp
> 170: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
> 250: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
> 318: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, run);
> 449: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 528: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 574: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 623: AWAIT_EXPECT_WEXITSTATUS_EQ(0, run);
> 844: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
> 918: AWAIT_EXPECT_WEXITSTATUS_EQ(128 + SIGKILL, status);
>
> src/tests/containerizer/capabilities_tests.cpp
> 98: AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
> 122: AWAIT_EXPECT_WEXITSTATUS_NE(0, s->status());
> 151: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s->status());
>
> 3rdparty/libprocess/src/tests/reap_tests.cpp
> 98: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
> 172: AWAIT_EXPECT_WEXITSTATUS_EQ(0, status);
>
> 3rdparty/libprocess/include/process/gtest.hpp
> 623:#define AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, duration) \
> 627:#define AWAIT_EXPECT_WEXITSTATUS_EQ(expected, actual) \
> 628: AWAIT_EXPECT_WEXITSTATUS_EQ_FOR(expected, actual, Seconds(15))
> 664:#define AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, duration) \
> 668:#define AWAIT_EXPECT_WEXITSTATUS_NE(expected, actual) \
> 669: AWAIT_EXPECT_WEXITSTATUS_NE_FOR(expected, actual, Seconds(15))
>
> 3rdparty/libprocess/src/tests/subprocess_tests.cpp
> 72: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 249: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 264: AWAIT_EXPECT_WEXITSTATUS_EQ(1, s.get().status());
> 323: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 344: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 371: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 411: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 442: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 465: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 497: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 531: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 562: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 599: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 617: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 700: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 763: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 789: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 818: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 847: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> 879: AWAIT_EXPECT_WEXITSTATUS_EQ(0, s.get().status());
> ```
>
> Especially the ones that do `128 + SIGKILL`; just WTF is that even doing? No one should have to go to [Stack Overflow](https://unix.stackexchange.com/a/99134) to understand what an assertion in a test is doing.
>
> It may be reasonable to go to `include/process/gtest.hpp` and make this easier, with `AWAIT_EXPECT_EXIT_SIGKILL(status)` (and like `AWAIT_EXPECT_EXIT_SUCCESS(status)` for `== 0`).
The weird exit code only happens to docker containers getting stopped/killed, so I think only the `128+SIGKILL` ones need to be cleaned up in `docker_tests.cpp` and `docker_containerizer_tests.cpp`
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
-----------------------------------------------------------
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Akash Gupta <ak...@hotmail.com>.
> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 130-137 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line130>
> >
> > Looks like instead of this adhoc routine we should rather introduce a root prefix in stout.
>
> Andrew Schwartzmeyer wrote:
> I don't think we should introduce this abstraction into stout until it becomes the case that other code needs it too. Currently, this abstraction is needed solely to make the Docker tests compatible on both platforms. Let's avoid unnecessary stout bloat.
Yeah, the function is just a helper function for some of the Docker tests. I don't see how this would be used anywhere else.
> On Jan. 10, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/tests/containerizer/docker_tests.cpp
> > Lines 139-153 (patched)
> > <https://reviews.apache.org/r/63862/diff/5/?file=1932789#file1932789line139>
> >
> > Again, this is something we should likely do in a broader scope. Chances are, someone else in a different place will try to solve the same problem.
>
> Andrew Schwartzmeyer wrote:
> Same as above. At the point of someone else solving the same problem, then it would make sense to move the code into a more general purpose location and reuse it. But we shouldn't do it until then, because otherwise we're just guessing at future technical needs.
This is specific to Docker and only for test code that checks the container exit value, which is onlt used here. So, I don't think other places will ever use this.
- Akash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
-----------------------------------------------------------
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review195133
-----------------------------------------------------------
src/tests/containerizer/docker_tests.cpp
Lines 130-137 (patched)
<https://reviews.apache.org/r/63862/#comment274279>
Looks like instead of this adhoc routine we should rather introduce a root prefix in stout.
src/tests/containerizer/docker_tests.cpp
Lines 139-153 (patched)
<https://reviews.apache.org/r/63862/#comment274280>
Again, this is something we should likely do in a broader scope. Chances are, someone else in a different place will try to solve the same problem.
- Alexander Rukletsov
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/5/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198468
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65839', '65861', '65862', '65840', '63862']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (144 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1246 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (40 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (44 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (87 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2586 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2611 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2476 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2501 ms total)
[----------] Global test environment tear-down
[==========] 916 tests from 91 test cases ran. (471473 ms total)
[ PASSED ] 915 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
1 FAILED TEST
YOU HAVE 210 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862/logs/mesos-tests-stderr.log):
```
I0301 20:24:08.754911 1120 master.cpp:10258] Updating the state of task 3fe9fb67-1013-4cb8-963c-e2cba420dec4 of framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0301 20:24:08.754911 7984 slave.cpp:3879] Shutting down framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000
I0301 20:24:08.754911 7984 slave.cpp:6586] Shutting down executor '3fe9fb67-1013-4cb8-963c-e2cba420dec4' of framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000 at executor(1)@10.3.1.11:53096
I0301 20:24:08.756911 7984 slave.cpp:922] Agent teI0301 20:24:08.048912 7596 exec.cpp:162] Version: 1.6.0
I0301 20:24:08.078908 3588 exec.cpp:236] Executor registered on agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0
I0301 20:24:08.082911 9236 executor.cpp:176] Received SUBSCRIBED event
I0301 20:24:08.087911 9236 executor.cpp:180] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0301 20:24:08.088912 9236 executor.cpp:176] Received LAUNCH event
I0301 20:24:08.093912 9236 executor.cpp:648] Starting task 3fe9fb67-1013-4cb8-963c-e2cba420dec4
I0301 20:24:08.176914 9236 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0301 20:24:08.718909 9236 executor.cpp:661] Forked command at 8280
I0301 20:24:08.757910 6008 exec.cpp:445] Executor asked to shutdown
I0301 20:24:08.758909 9236 executor.cpp:176] Received SHUTDOWN event
I0301 20:24:08.758909 9236 executor.cpp:758] Shutting down
I0301 20:24:08.758909 9236 executor.cpp:868] Sending SIGTERM to process tree at pid 8rminating
W0301 20:24:08.757910 7984 slave.cpp:3875] Ignoring shutdown framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000 because it is terminating
I0301 20:24:08.757910 1120 master.cpp:10357] Removing task 3fe9fb67-1013-4cb8-963c-e2cba420dec4 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000 on agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:24:08.760911 1120 master.cpp:1306] Agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0301 20:24:08.760911 1120 master.cpp:3276] Disconnecting agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:24:08.760911 1120 master.cpp:3295] Deactivating agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 at slave(398)@10.3.1.11:53075 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0301 20:24:08.761909 4568 containerizer.cpp:2338] Destroying container 2df2a9b1-5641-4637-873f-ec4e24eb568f in RUNNING state
I0301 20:24:08.761909 4568 containerizer.cpp:2952] Transitioning the state of container 2df2a9b1-5641-4637-873f-ec4e24eb568f from RUNNING to DESTROYING
I0301 20:24:08.761909 1740 hierarchical.cpp:344] Removed framework 5141e1be-97ce-44d2-84a8-8183a8110499-0000
I0301 20:24:08.761909 1740 hierarchical.cpp:766] Agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0 deactivated
I0301 20:24:08.762908 4568 launcher.cpp:156] Asked to destroy container 2df2a9b1-5641-4637-873f-ec4e24eb568f
I0301 20:24:08.788137 1120 containerizer.cpp:2791] Container 2df2a9b1-5641-4637-873f-ec4e24eb568f has exited
I0301 20:24:08.819914 8608 master.cpp:1149] Master terminating
I0301 20:24:08.822914 2552 hierarchical.cpp:609] Removed agent 5141e1be-97ce-44d2-84a8-8183a8110499-S0
I0301 20:24:09.530915 5380 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/7/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198583
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65839, 65861, 65862, 65840, 63862]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/8/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198565
-----------------------------------------------------------
What's the status of this patch?
- Andrew Schwartzmeyer
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/7/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198494
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65839, 65861, 65862, 65840, 63862]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 6:33 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/7/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198351
-----------------------------------------------------------
PASS: Mesos patch 63862 was successfully built and tested.
Reviews applied: `['63862']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
- Mesos Reviewbot Windows
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/6/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198756
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/8/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/#review198577
-----------------------------------------------------------
PASS: Mesos patch 63862 was successfully built and tested.
Reviews applied: `['65839', '65861', '65862', '65840', '63862']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63862
- Mesos Reviewbot Windows
On Jan. 5, 2018, 10:33 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63862/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 10:33 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-7342
> https://issues.apache.org/jira/browse/MESOS-7342
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ported the disabled tests to run on Windows. The following tests
> could not be ported due to Windows platform limitations and remain
> diabled:
> - ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
> sandbox).
> - ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
> - ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_common.hpp 3d69e54647d34ba0f33930d84db6c052e46ebc89
> src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
>
>
> Diff: https://reviews.apache.org/r/63862/diff/8/
>
>
> Testing
> -------
>
> Windows mesos-test:
> [==========] 754 tests from 77 test cases ran. (270586 ms total)
> [ PASSED ] 754 tests.
>
>
> Windows DockerTest only:
> [==========] 11 tests from 1 test case ran. (85617 ms total)
> [ PASSED ] 11 tests.
>
> Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
> [==========] 12 tests from 1 test case ran. (12413 ms total)
> [ PASSED ] 12 tests.
>
>
> Thanks,
>
> Akash Gupta
>
>
Re: Review Request 63862: Windows: Ported docker_tests.cpp.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63862/
-----------------------------------------------------------
(Updated Jan. 5, 2018, 6:33 p.m.)
Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu, John Kordich, Joseph Wu, and Michael Park.
Changes
-------
Updated to reflect network changes.
Bugs: MESOS-7342
https://issues.apache.org/jira/browse/MESOS-7342
Repository: mesos
Description
-------
Ported the disabled tests to run on Windows. The following tests
could not be ported due to Windows platform limitations and remain
diabled:
- ROOT_DOCKER_MountRelativeContainerPath (can't mount volumes inside
sandbox).
- ROOT_DOCKER_NVIDIA_GPU_DeviceAllow (no GPU container support).
- ROOT_DOCKER_NVIDIA_GPU_InspectDevices (no GPU container support).
Diffs (updated)
-----
src/tests/containerizer/docker_tests.cpp 0ac4a79e03d5e11ead5a57a9749e26c20a1ddd57
Diff: https://reviews.apache.org/r/63862/diff/5/
Changes: https://reviews.apache.org/r/63862/diff/4-5/
Testing
-------
Windows mesos-test:
[==========] 754 tests from 77 test cases ran. (270586 ms total)
[ PASSED ] 754 tests.
Windows DockerTest only:
[==========] 11 tests from 1 test case ran. (85617 ms total)
[ PASSED ] 11 tests.
Linux DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU):
[==========] 12 tests from 1 test case ran. (12413 ms total)
[ PASSED ] 12 tests.
Thanks,
Akash Gupta