You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/15 18:50:35 UTC
[GitHub] [arrow] lidavidm opened a new pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
lidavidm opened a new pull request #12639:
URL: https://github.com/apache/arrow/pull/12639
Fix the failing Java/Python JNI integration build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068345301
@github-actions crossbow submit conda-python-java-integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068383845
Passing run: https://github.com/apache/arrow/runs/5559475676?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068400316
@github-actions crossbow submit test-conda-python-java-integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#discussion_r827935413
##########
File path: python/setup.py
##########
@@ -421,7 +421,8 @@ def _bundle_cython_cpp(self, name, lib_path):
def _failure_permitted(self, name):
if name == '_parquet' and not self.with_parquet:
return True
- if name == '_parquet_encryption' and not self.with_parquet_encryption:
+ if name == '_parquet_encryption' and \
+ not (self.with_parquet and self.with_parquet_encryption):
Review comment:
I fixed the script as well but IMO setup.py still either needs to 1) implicitly turn on Parquet if encryption is requested or 2) implicitly turn off encryption if Parquet is not enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068343445
@github-actions crossbow submit test-conda-python-java-integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#discussion_r827577004
##########
File path: python/setup.py
##########
@@ -421,7 +421,8 @@ def _bundle_cython_cpp(self, name, lib_path):
def _failure_permitted(self, name):
if name == '_parquet' and not self.with_parquet:
return True
- if name == '_parquet_encryption' and not self.with_parquet_encryption:
+ if name == '_parquet_encryption' and \
+ not (self.with_parquet and self.with_parquet_encryption):
Review comment:
From the name, looks to me `with_parquet_encryption == True` implies `with_parquet == True`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068344961
```
Unable to match any tasks for `test-conda-python-java-integration`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1988665261```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068348457
```
Unable to match any tasks for `conda-python-java-integration`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1988674302```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068401393
Revision: 31d96616f6f9ef5bfafd8aa1ea6fd2c54c353df8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1768](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1768)
|Task|Status|
|----|------|
|test-conda-python-java-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1768-github-test-conda-python-java-integration)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#issuecomment-1068442469
The crossbow build isn't happy, but it's for unrelated reasons now - the original issue should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#discussion_r827934389
##########
File path: python/setup.py
##########
@@ -421,7 +421,8 @@ def _bundle_cython_cpp(self, name, lib_path):
def _failure_permitted(self, name):
if name == '_parquet' and not self.with_parquet:
return True
- if name == '_parquet_encryption' and not self.with_parquet_encryption:
+ if name == '_parquet_encryption' and \
+ not (self.with_parquet and self.with_parquet_encryption):
Review comment:
We could go that way, yes, and have one implicitly enable the other. We could also just fix the CI script not to have conflicting defaults: https://github.com/apache/arrow/blob/a32f454d86560ab357b419273bb08678e1632d30/ci/scripts/python_build.sh#L60-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12639:
URL: https://github.com/apache/arrow/pull/12639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org