Re: Review Request 65950: Add support to allow clients to access resource permissions stored in Ranger

[Abhay Kulkarni <ak...@hortonworks.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65950/#review208528
-----------------------------------------------------------




hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
Lines 1377 (patched)
<https://reviews.apache.org/r/65950/#comment292515>

    Is the check, permissionAccess.getValue().getIsFinal(), required? All permissionAccesses are set to final in RangerResourceACLs.finalizeAcls().


- Abhay Kulkarni


On Aug. 20, 2018, 6:14 p.m., Ankit Singhal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65950/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2018, 6:14 p.m.)
> 
> 
> Review request for ranger and Ramesh Mani.
> 
> 
> Bugs: RANGER-1958
>     https://issues.apache.org/jira/browse/RANGER-1958
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-1958 [HBase] Implement getUserPermissions API of AccessControlService.Interface to allow clients to access HBase permissions stored in Ranger
> 
> 
> Diffs
> -----
> 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/AuthorizationSession.java cdaad00a4 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java d85339a09 
>   hbase-agent/src/test/java/org/apache/ranger/authorization/hbase/HBaseRangerAuthorizationTest.java 38408855d 
>   hbase-agent/src/test/resources/hbase-policies.json b7b44c9ea 
> 
> 
> Diff: https://reviews.apache.org/r/65950/diff/2/
> 
> 
> Testing
> -------
> 
> Unit testing is done
> 
> 
> Thanks,
> 
> Ankit Singhal
> 
>