You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/26 09:46:23 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

poorbarcode opened a new pull request, #17837:
URL: https://github.com/apache/pulsar/pull/17837

   Fixes:
   
   -#14109
   
   
   ### Motivation
   
   The expected execution flow for this test is: 
   
   1. send 505 messages
   2. commit 10 transactions, every transaction ack 50 messages
   3. receive the last 5 messages in the last transaction, wait for transaction timeout
   4. confirm that the last 5 messages can be consumed by new consumer
   
   <strong>(High light)</strong> The default value for transaction TTL is 10 seconds, and the default value for `Awaitility.await` is also 10 seconds,  so this test is not stable.
   
   Note: This is a guess cause, the problem is not reproduced locally, but after TTL is set to 11s, the probability of the problem occurring is 100%.
   
   ### Modifications
   
   Fix flaky test
   - set transaction TTL to 5s
   
   Other changes
   - define a name for the task thread
   - acknowledge the last 5 messages
   
   ### Documentation
   
   - [ ] `doc-required` 
   
   - [ ] `doc-not-needed` 
   
   - [ ] `doc` 
   
   - [ ] `doc-complete`
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   
   - https://github.com/poorbarcode/pulsar/pull/13
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17837:
URL: https://github.com/apache/pulsar/pull/17837#issuecomment-1260445313

   Can this PR merge? (^_^)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage
URL: https://github.com/apache/pulsar/pull/17837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17837:
URL: https://github.com/apache/pulsar/pull/17837#issuecomment-1257799011

   @poorbarcode Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] congbobo184 merged pull request #17837: [fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage

Posted by GitBox <gi...@apache.org>.
congbobo184 merged PR #17837:
URL: https://github.com/apache/pulsar/pull/17837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org