[GitHub] [spark] cloud-fan commented on a diff in pull request #41265: [SPARK-43596][SQL] Handle IsNull predicate in rewriteDomainJoins

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41265:
URL: https://github.com/apache/spark/pull/41265#discussion_r1204915836


##########
sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-select.sql:
##########
@@ -240,3 +240,9 @@ SELECT c, (
 SELECT *, (SELECT count(1) is null FROM t2 WHERE t1.c1 = t2.c1) FROM t1;
 
 select (select f from (select false as f, max(c2) from t1 where t1.c1 = t1.c1)) from t2;
+
+-- SPARK-43596: handle IsNull when rewriting the domain join
+set spark.sql.optimizer.optimizeOneRowRelationSubquery.alwaysInline=false;

Review Comment:
   let's set the config back after the test query, in case people add more queries later and mistakenly run with this conf disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org