You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/25 08:14:14 UTC
[GitHub] [incubator-eventmesh] horoc opened a new pull request, #1412: [ISSUE #1411] Add GRPC protocol metrics
horoc opened a new pull request, #1412:
URL: https://github.com/apache/incubator-eventmesh/pull/1412
### Motivation
#1411
### Modifications
Add GRPC protocol metrics
### Documentation
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1412:
URL: https://github.com/apache/incubator-eventmesh/pull/1412#issuecomment-1257148412
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1412](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1052874) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/86455c587c5bb0653ea2462b4ac5ac242299254f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86455c5) will **decrease** coverage by `0.09%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## master #1412 +/- ##
============================================
- Coverage 10.43% 10.33% -0.10%
- Complexity 764 773 +9
============================================
Files 435 441 +6
Lines 26564 26900 +336
Branches 2927 2929 +2
============================================
+ Hits 2771 2780 +9
- Misses 23534 23859 +325
- Partials 259 261 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../metrics/prometheus/PrometheusMetricsRegistry.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvUHJvbWV0aGV1c01ldHJpY3NSZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ics/prometheus/metrics/PrometheusGrpcExporter.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLW1ldHJpY3MtcGx1Z2luL2V2ZW50bWVzaC1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9tZXRyaWNzL3Byb21ldGhldXMvbWV0cmljcy9Qcm9tZXRoZXVzR3JwY0V4cG9ydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/eventmesh/runtime/boot/EventMeshGrpcServer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoR3JwY1NlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/grpc/consumer/ConsumerManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9jb25zdW1lci9Db25zdW1lck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...core/protocol/grpc/consumer/EventMeshConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9jb25zdW1lci9FdmVudE1lc2hDb25zdW1lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...l/grpc/processor/BatchPublishMessageProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9jZXNzb3IvQmF0Y2hQdWJsaXNoTWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...protocol/grpc/processor/ReplyMessageProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9jZXNzb3IvUmVwbHlNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...otocol/grpc/processor/RequestMessageProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9jZXNzb3IvUmVxdWVzdE1lc3NhZ2VQcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ocol/grpc/processor/SendAsyncMessageProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9jZXNzb3IvU2VuZEFzeW5jTWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...me/core/protocol/grpc/service/ConsumerService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9zZXJ2aWNlL0NvbnN1bWVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/1412/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc closed pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
Posted by GitBox <gi...@apache.org>.
horoc closed pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
URL: https://github.com/apache/incubator-eventmesh/pull/1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc commented on pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
Posted by GitBox <gi...@apache.org>.
horoc commented on PR #1412:
URL: https://github.com/apache/incubator-eventmesh/pull/1412#issuecomment-1259505647
I will close it first and submit it in other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on code in PR #1412:
URL: https://github.com/apache/incubator-eventmesh/pull/1412#discussion_r979523969
##########
gradle.properties:
##########
@@ -32,3 +32,4 @@ apachePassWord=
signEnabled=false
org.gradle.warning.mode=none
+org.gradle.jvmargs=-Xmx4096m
Review Comment:
Why you add this param ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] horoc commented on a diff in pull request #1412: [ISSUE #1411] Add GRPC protocol metrics
Posted by GitBox <gi...@apache.org>.
horoc commented on code in PR #1412:
URL: https://github.com/apache/incubator-eventmesh/pull/1412#discussion_r979537430
##########
gradle.properties:
##########
@@ -32,3 +32,4 @@ apachePassWord=
signEnabled=false
org.gradle.warning.mode=none
+org.gradle.jvmargs=-Xmx4096m
Review Comment:
> Why you add this param ?
@xwm1992 oh, I will delete that. just for debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org