[jira] [Commented] (DERBY-5164) Provide a framework to test upgrade between point releases. Currently, the upgrade testing happens between two major versions.

["Mamta A. Satoor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078910#comment-13078910 ] 

Mamta A. Satoor commented on DERBY-5164:
----------------------------------------

We have a checkin in the 10.7 codeline which does the testing from point release of 10.7 codeline(namely 10.7.1.1) to the top of the 10.7 codeline. That checkin went is as revision r1133495, The commit comments for that change for reference are as below. Based on this, I will go ahead and close this jira.

Backporting revision 1132664 from trunk to 10.8 codeline. In addition to the backport, had to make couple changes by hand. Added 10.7.1.1 to the list of old revisions of Derby from which there will be upgrade to current 10.7 codeline. The reason for adding 10.7.1.1 is DERBY-5121 which caused data corruption is this release. This was fixed in the 10.7 codeline after 10.7.1.1 and we want to make sure that the faulty triggers created in 10.7.1.1 get fixed when taken to 10.7 codeline.

Also, normally, when an older release is hard upgraded to the codeline, the database can't be booted again with the old release. But when we are testing upgrade from 10.7.1.1 to current codeline on 10.7, we can always goback to 10.7.1.1 because it is simply a point release upgrade. I have changed the upgrade test to allow this going back to 10.7.1.1 after the db has been hard upgraded to 10.7 codeline.

Commit comments for 1132664
Giving the upgrade tests in Changes10_8 a little more thought, I feel that the more appropriate place for the tests will be in upgradeTests.BasicSetup. The reason for this is that the tests are creating triggers and testing the results when they get fired. This kind of testing is not unique to any particular Derby release and hence it is better for them to go in BasicSetup to make sure that the results are consistent between various phases of upgrades. We do already know that because of the bug DERBY-5121, the results will be incorrect in 10.7.1.1 and the test is verifying those incorrect reulsts for 10.7.1.1. Based on this, I am putting these set of trigger tests in BasicSetup.java This makes Changes10_8.java to have no tests left in it and hence we can delete Changes10_8.java from svn.

> Provide a framework to test upgrade between point releases. Currently, the upgrade testing happens between two major versions.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5164
>                 URL: https://issues.apache.org/jira/browse/DERBY-5164
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.0.2.1, 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 10.5.3.0, 10.6.2.1, 10.7.1.1
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: derby5164_patch1_diff.txt, derby5164_patch1_stat.txt
>
>
> DERBY-5121 found a corruption problem caused by triggers in DERBY release 10.7.1.1 A fix for this has been provided in trunk(10.8) and the 10.7 codeline. 10.7.1.1 database upgrade to any one of these 2 codelines will fix the triggers causing the corruption. I was able to write upgrade tests for 10.8 codeline but not for 10.7 codeline. The reason for this can be found in the comment insdie org.apache.derbyTesting.functionTests.tests.upgradeTests.UpgradeRun:baseSuite 
>     * Changes are only added if the old version is older than
>     * then version the changes represent. Thus Changes10_2
>     * is not added if the old database (upgrade from) is already
>     * at 10.2, since Changes10_2 is intended to test upgrade
>     * from an older version to 10.2.
> The last line in the comment "since Changes10_2 is intended to test upgrade from an older version to 10.2." is not really true specifically for DERBY-5121. We want to test upgrade from 10.7.1.1 to next point release/codeline of 10.7.
> Providing this framework should not be too hard. I just wanted to create this jira so we can keep track of the issue.
> More information on this issue can be found at http://mail-archives.apache.org/mod_mbox/db-derby-dev/201103.mbox/%3CAANLkTinYKkO0nef+8gM4oJmRE0jnzC-qbXy3ZN4_e3oG@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira