You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by Alex Harui <ah...@adobe.com> on 2014/06/10 19:05:04 UTC
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix
callouts closing when selecting dates in DateFields
-1 for reasons stated below.
Justin, you never responded so I'm thinking my attempts to ask you about
this have been missed in all the other noise.
-Alex
On 5/26/14 10:12 PM, "Alex Harui" <ah...@adobe.com> wrote:
>This change broke Falcon, although Falcon is not reporting the failure
>correctly. And I'm sort of surprised it didn't break the SDK build
>because it introduces a dependency from spark.swc to mx.swc and mx.swc is
>not listed in the set of libraries used to build experimental.swc.
>
>It is also not a good idea to start dragging mx stuff into spark-only
>apps. Might affect mobile app sizes and might affect those with
>spark-only build setups.
>
>I'm not familiar with Callout, but in other components with drop downs,
>the drop down's owner property is set to the base component, then you
>check to see if the component "owns" the clicked item. Can similar logic
>be used here and eliminate the mx.swc dependency?
>
>Thanks,
>-Alex
>
>On 5/18/14 12:30 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
>
>>Repository: flex-sdk
>>Updated Branches:
>> refs/heads/develop 3a087a60e -> 080f5e64d
>>
>>
>>FLEX-34078 fix callouts closing when selecting dates in DateFields
>>
>>
>>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/080f5e64
>>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/080f5e64
>>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/080f5e64
>>
>>Branch: refs/heads/develop
>>Commit: 080f5e64d5718d76c51ecf6b07552b8bfc1b112e
>>Parents: 3a087a6
>>Author: Justin Mclean <jm...@apache.org>
>>Authored: Sun May 18 12:30:41 2014 -0700
>>Committer: Justin Mclean <jm...@apache.org>
>>Committed: Sun May 18 12:30:41 2014 -0700
>>
>>----------------------------------------------------------------------
>> .../src/spark/components/supportClasses/DropDownController.as | 3
>>+++
>> 1 file changed, 3 insertions(+)
>>----------------------------------------------------------------------
>>
>>
>>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/080f5e64/frameworks/
>>p
>>rojects/spark/src/spark/components/supportClasses/DropDownController.as
>>----------------------------------------------------------------------
>>diff --git
>>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>index e1ff2fd..3641111 100644
>>---
>>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>+++
>>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>@@ -38,6 +38,7 @@ import mx.managers.ISystemManager;
>>
>> import spark.components.DropDownList;
>> import spark.events.DropDownEvent;
>>+import mx.controls.CalendarLayout;
>>
>> use namespace mx_internal;
>>
>>@@ -613,6 +614,8 @@ public class DropDownController extends
>>EventDispatcher
>> var document:Object = (target as IUIComponent).document;
>> if (("hostComponent" in document) &&
>>document.hostComponent is DropDownList)
>> return;
>>+ if (target.parent is CalendarLayout)
>>+ return;
>> }
>>
>> if (hitAreaAdditions != null)
>>
>
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I saw he made two commits yesterday and thought it would be a fair
> assumption he'd have enough bandwidth to do a revert…
I may do but not currently - that was via WiFi on a train.
Justin
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix
callouts closing when selecting dates in DateFields
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I saw he made two commits yesterday and thought it would be a fair
assumption he'd have enough bandwidth to do a revert…
EdB
On Friday, June 13, 2014, Kessler CTR Mark J <ma...@usmc.mil>
wrote:
> I think he said he was on travel and had limited internet access.
> Thinking that means someone else will have to do it, or when he gets to a
> reliable connection.
>
> -Mark
>
> -----Original Message-----
> From: Erik de Bruin [mailto:erik@ixsoftware.nl <javascript:;>]
> Sent: Friday, June 13, 2014 10:45 AM
> To: dev@flex.apache.org <javascript:;>
> Subject: Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix
> callouts closing when selecting dates in DateFields
>
> Justin,
>
> This is the other commit that has been vetoed. Please revert asap. We need
> clean builds and Mustella to pass.
>
> EdB
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
RE: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix
callouts closing when selecting dates in DateFields
Posted by Kessler CTR Mark J <ma...@usmc.mil>.
I think he said he was on travel and had limited internet access. Thinking that means someone else will have to do it, or when he gets to a reliable connection.
-Mark
-----Original Message-----
From: Erik de Bruin [mailto:erik@ixsoftware.nl]
Sent: Friday, June 13, 2014 10:45 AM
To: dev@flex.apache.org
Subject: Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields
Justin,
This is the other commit that has been vetoed. Please revert asap. We need
clean builds and Mustella to pass.
EdB
Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix
callouts closing when selecting dates in DateFields
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Justin,
This is the other commit that has been vetoed. Please revert asap. We need
clean builds and Mustella to pass.
EdB
On Tuesday, June 10, 2014, Alex Harui <ah...@adobe.com> wrote:
> -1 for reasons stated below.
>
> Justin, you never responded so I'm thinking my attempts to ask you about
> this have been missed in all the other noise.
>
> -Alex
>
> On 5/26/14 10:12 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> >This change broke Falcon, although Falcon is not reporting the failure
> >correctly. And I'm sort of surprised it didn't break the SDK build
> >because it introduces a dependency from spark.swc to mx.swc and mx.swc is
> >not listed in the set of libraries used to build experimental.swc.
> >
> >It is also not a good idea to start dragging mx stuff into spark-only
> >apps. Might affect mobile app sizes and might affect those with
> >spark-only build setups.
> >
> >I'm not familiar with Callout, but in other components with drop downs,
> >the drop down's owner property is set to the base component, then you
> >check to see if the component "owns" the clicked item. Can similar logic
> >be used here and eliminate the mx.swc dependency?
> >
> >Thanks,
> >-Alex
> >
> >On 5/18/14 12:30 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
> >
> >>Repository: flex-sdk
> >>Updated Branches:
> >> refs/heads/develop 3a087a60e -> 080f5e64d
> >>
> >>
> >>FLEX-34078 fix callouts closing when selecting dates in DateFields
> >>
> >>
> >>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> >>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/080f5e64
> >>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/080f5e64
> >>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/080f5e64
> >>
> >>Branch: refs/heads/develop
> >>Commit: 080f5e64d5718d76c51ecf6b07552b8bfc1b112e
> >>Parents: 3a087a6
> >>Author: Justin Mclean <jm...@apache.org>
> >>Authored: Sun May 18 12:30:41 2014 -0700
> >>Committer: Justin Mclean <jm...@apache.org>
> >>Committed: Sun May 18 12:30:41 2014 -0700
> >>
> >>----------------------------------------------------------------------
> >> .../src/spark/components/supportClasses/DropDownController.as | 3
> >>+++
> >> 1 file changed, 3 insertions(+)
> >>----------------------------------------------------------------------
> >>
> >>
> >>
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/080f5e64/frameworks/
> >>p
> >>rojects/spark/src/spark/components/supportClasses/DropDownController.as
> >>----------------------------------------------------------------------
> >>diff --git
> >>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
> >>o
> >>ntroller.as
> >>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
> >>o
> >>ntroller.as
> >>index e1ff2fd..3641111 100644
> >>---
> >>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
> >>o
> >>ntroller.as
> >>+++
> >>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
> >>o
> >>ntroller.as
> >>@@ -38,6 +38,7 @@ import mx.managers.ISystemManager;
> >>
> >> import spark.components.DropDownList;
> >> import spark.events.DropDownEvent;
> >>+import mx.controls.CalendarLayout;
> >>
> >> use namespace mx_internal;
> >>
> >>@@ -613,6 +614,8 @@ public class DropDownController extends
> >>EventDispatcher
> >> var document:Obj
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl