You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jspwiki.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/28 09:30:00 UTC

[jira] [Commented] (JSPWIKI-1156) Remove 'protected' member in 'final' class

    [ https://issues.apache.org/jira/browse/JSPWIKI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435281#comment-17435281 ] 

ASF subversion and git services commented on JSPWIKI-1156:
----------------------------------------------------------

Commit 551de885142b6c05007122201d027e1bed6d4c4c in jspwiki's branch refs/heads/master from Arturo Bernal
[ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=551de88 ]

JSPWIKI-1156 - Remove 'protected' member in 'final' class.


> Remove 'protected' member in 'final' class
> ------------------------------------------
>
>                 Key: JSPWIKI-1156
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-1156
>             Project: JSPWiki
>          Issue Type: Improvement
>            Reporter: Arturo Bernal
>            Priority: Minor
>              Labels: pull-request-available
>
> Since final classes cannot be inherited, marking the method as protected may be confusing. 
> IMO It is better to declare such members as private or package-visible instead.
>  
> Of course I can be wrong.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)