You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2019/07/30 07:54:44 UTC
Review Request 71198: Fixed GLog linking with debug targets.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71198/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
When building with debug symbols, the GLog library will be called 'libglogd' instead of 'libglog'. This is resolved by adding a suffix, similar to how it's already done for the Protocol Buffers library.
Diffs
-----
3rdparty/CMakeLists.txt a143b7043
Diff: https://reviews.apache.org/r/71198/diff/1/
Testing
-------
Build Mesos with `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug`
Thanks,
Jan Schlicht
Re: Review Request 71198: Fixed GLog linking with debug targets.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71198/#review216959
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 30, 2019, 12:54 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71198/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 12:54 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When building with debug symbols, the GLog library will be called
> 'libglogd' instead of 'libglog'. This is resolved by adding a suffix,
> similar to how it's already done for the Protocol Buffers library.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt a143b7043
>
>
> Diff: https://reviews.apache.org/r/71198/diff/1/
>
>
> Testing
> -------
>
> Build Mesos with `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug`
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 71198: Fixed GLog linking with debug targets.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71198/#review216948
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On July 30, 2019, 9:54 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71198/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:54 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When building with debug symbols, the GLog library will be called
> 'libglogd' instead of 'libglog'. This is resolved by adding a suffix,
> similar to how it's already done for the Protocol Buffers library.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt a143b7043
>
>
> Diff: https://reviews.apache.org/r/71198/diff/1/
>
>
> Testing
> -------
>
> Build Mesos with `cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug`
>
>
> Thanks,
>
> Jan Schlicht
>
>