[GitHub] [pulsar] gvolpe commented on a diff in pull request #15190: [improve][java-client] Better error message for `reconsumeLater`

[GitBox <gi...@apache.org>]

gvolpe commented on code in PR #15190:
URL: https://github.com/apache/pulsar/pull/15190#discussion_r851906809


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -466,7 +466,7 @@ public CompletableFuture<Void> reconsumeLaterAsync(Message<?> message, long dela
     public CompletableFuture<Void> reconsumeLaterAsync(
             Message<?> message, Map<String, String> customProperties, long delayTime, TimeUnit unit) {
         if (!conf.isRetryEnable()) {
-            return FutureUtil.failedFuture(new PulsarClientException("reconsumeLater method not support!"));
+            return FutureUtil.failedFuture(new PulsarClientException("reconsumeLater method not supported! Have you enabled retries in your consumer?"));

Review Comment:
   I agree with the second part, but disagree with the first part: we are talking about the method, which is not supported (we can't enable `reconsumeLater`). How about this?
   
   "reconsumeLater method not supported! Please set `enableRetry(true)` in your `ConsumerBuilder`"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org