[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4285: HBASE-26891 Make MetricsConnection scope configurable

[GitBox <gi...@apache.org>]

bbeaudreault commented on code in PR #4285:
URL: https://github.com/apache/hbase/pull/4285#discussion_r841108646


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##########
@@ -132,7 +133,8 @@ public AsyncConnectionImpl(Configuration conf, ConnectionRegistry registry, Stri
     this.connConf = new AsyncConnectionConfiguration(conf);
     this.registry = registry;
     if (conf.getBoolean(CLIENT_SIDE_METRICS_ENABLED_KEY, false)) {
-      this.metrics = Optional.of(new MetricsConnection(this.toString(), () -> null, () -> null));
+      String scope = conf.get(METRICS_SCOPE_KEY, clusterId + "-" + hashCode());

Review Comment:
   If you disagree or think it's a compatibility issue, i'll be happy to revert that part. Internally, I plan to override scope in all cases, but thought this might be a good quality of life improvement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org