[GitHub] [flink] lirui-apache commented on a change in pull request #8890: [FLINK-12989][hive]: Generate HiveTableSink from from a Hive table

[GitBox <gi...@apache.org>]

lirui-apache commented on a change in pull request #8890: [FLINK-12989][hive]: Generate HiveTableSink from from a Hive table
URL: https://github.com/apache/flink/pull/8890#discussion_r297494123
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableFactory.java
 ##########
 @@ -31,13 +32,22 @@
 import org.apache.flink.types.Row;
 import org.apache.flink.util.Preconditions;
 
+import org.apache.hadoop.mapred.JobConf;
+
 import java.util.List;
 import java.util.Map;
 
+import static org.apache.flink.util.Preconditions.checkNotNull;
+
 /**
  * A table factory implementation for tables stored in Hive catalog.
  */
 public class HiveTableFactory implements TableSourceFactory<Row>, TableSinkFactory<Row> {
+	private HiveCatalog hiveCatalog;
 
 Review comment:
   How is the HiveCatalog used in the factory? Seems we just need to get a HiveConf from it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services