You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Richard Jones (JIRA)" <ji...@apache.org> on 2009/01/15 15:38:59 UTC
[jira] Created: (THRIFT-266) Erlang atoms must always start with
lower-case character
Erlang atoms must always start with lower-case character
--------------------------------------------------------
Key: THRIFT-266
URL: https://issues.apache.org/jira/browse/THRIFT-266
Project: Thrift
Issue Type: Bug
Components: Compiler (Erlang)
Environment: Linux x86/x86_64
Reporter: Richard Jones
Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-266) Erlang atoms must always start with
lower-case character
Posted by "Richard Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Jones updated THRIFT-266:
---------------------------------
Attachment: erlang-record-uncapitalize.patch
Forces first char of atom to lowercase for struct fields
> Erlang atoms must always start with lower-case character
> --------------------------------------------------------
>
> Key: THRIFT-266
> URL: https://issues.apache.org/jira/browse/THRIFT-266
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Erlang)
> Environment: Linux x86/x86_64
> Reporter: Richard Jones
> Attachments: erlang-record-uncapitalize.patch
>
>
> Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
> If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-266) Erlang atoms must always start with
lower-case character
Posted by "Richard Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688480#action_12688480 ]
Richard Jones commented on THRIFT-266:
--------------------------------------
Nope, please commit it :)
RJ
> Erlang atoms must always start with lower-case character
> --------------------------------------------------------
>
> Key: THRIFT-266
> URL: https://issues.apache.org/jira/browse/THRIFT-266
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Erlang)
> Environment: Linux x86/x86_64
> Reporter: Richard Jones
> Attachments: erlang-record-uncapitalize.patch
>
>
> Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
> If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-266) Erlang atoms must always start with
lower-case character
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688466#action_12688466 ]
Bryan Duxbury commented on THRIFT-266:
--------------------------------------
Any reason not to commit this patch?
> Erlang atoms must always start with lower-case character
> --------------------------------------------------------
>
> Key: THRIFT-266
> URL: https://issues.apache.org/jira/browse/THRIFT-266
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Erlang)
> Environment: Linux x86/x86_64
> Reporter: Richard Jones
> Attachments: erlang-record-uncapitalize.patch
>
>
> Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
> If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-266) Erlang atoms must always start with
lower-case character
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664127#action_12664127 ]
Todd Lipcon commented on THRIFT-266:
------------------------------------
lgtm. +1
> Erlang atoms must always start with lower-case character
> --------------------------------------------------------
>
> Key: THRIFT-266
> URL: https://issues.apache.org/jira/browse/THRIFT-266
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Erlang)
> Environment: Linux x86/x86_64
> Reporter: Richard Jones
> Attachments: erlang-record-uncapitalize.patch
>
>
> Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
> If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-266) Erlang atoms must always start with
lower-case character
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-266.
----------------------------------
Resolution: Fixed
Assignee: Richard Jones
Committed. Thanks for the patch, sorry about the wait!
> Erlang atoms must always start with lower-case character
> --------------------------------------------------------
>
> Key: THRIFT-266
> URL: https://issues.apache.org/jira/browse/THRIFT-266
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Erlang)
> Environment: Linux x86/x86_64
> Reporter: Richard Jones
> Assignee: Richard Jones
> Attachments: erlang-record-uncapitalize.patch
>
>
> Field names in erlang records (structs) need to start with a lower-case character to be valid Erlang.
> If the .thrift file uses an upper-case character, the compiler should lower-case it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.