You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2016/01/14 18:36:37 UTC

[GitHub] incubator-trafodion pull request: TRAFODION-1754 Showddl component...

GitHub user robertamarton opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/267

    TRAFODION-1754 Showddl component does not display grants correctly

    Showddl should be displaying grants on an operation in a manner that allows
    the privileges to be recreated.  Currently, they are returned in the order
    in which they are read from the metadata.
    
    While working on this JIRA, several issues were fixed including:
    
    - Consolidated privilege values into one location - NAUserId.h. They used to be
      stored in NAUserId.h, ComSmallDefs.h, and PrivMgrDefs.h
    - The check for getting the next available role ID was not correct.
    - PrivMgrPrivileges::hasColWGO has incorrect indexing
    - PrivMgrComponentPrivileges::selectAllWhere has incorrect error checking

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion priv-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----
commit 17d1b177864141e8670dcc8584f95eb0d845e756
Author: Roberta Marton <ro...@apache.org>
Date:   2016-01-14T17:29:35Z

    TRAFODION-1754 Showddl component does not display grants correctly
    
    Showddl should be displaying grants on an operation in a manner that allows
    the privileges to be recreated.  Currently, they are returned in the order
    in which they are read from the metadata.
    
    While working on this JIRA, several issues were fixed including:
    
    - Consolidated privilege values into one location - NAUserId.h. They used to be
      stored in NAUserId.h, ComSmallDefs.h, and PrivMgrDefs.h
    - The check for getting the next available role ID was not correct.
    - PrivMgrPrivileges::hasColWGO has incorrect indexing
    - PrivMgrComponentPrivileges::selectAllWhere has incorrect error checking

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request: TRAFODION-1754 Showddl component...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---