You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2018/07/03 21:31:09 UTC
Review Request 67820: Fixed XfsDiskIsolatorProcess::recover()
signature.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and James Peach.
Repository: mesos
Description
-------
Change r/67312 replaced std::list with std::vector in several places
including the Isolator interface. However XfsDiskIsolatorProcess was not
updated and because of that its recover() method became "disabled".
Diffs
-----
src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
Diff: https://reviews.apache.org/r/67820/diff/1/
Testing
-------
Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
Thanks,
Ilya Pronin
Re: Review Request 67820: Fixed recover() virtual method signature in
several isolators.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205774
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 5, 2018, 9:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
> std::vector in several places including the Isolator interface. However
> XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
> NetworkPortsIsolatorProcess were not updated and because of that their
> recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c
> src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d
> src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/2/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 67820: Fixed recover() virtual method signature in
several isolators.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/
-----------------------------------------------------------
(Updated July 5, 2018, 2:31 p.m.)
Review request for mesos, Benjamin Mahler and James Peach.
Changes
-------
Expanded the change to include `network/port_mapping` and `network/ports` isolators.
Summary (updated)
-----------------
Fixed recover() virtual method signature in several isolators.
Repository: mesos
Description (updated)
-------
Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
std::vector in several places including the Isolator interface. However
XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
NetworkPortsIsolatorProcess were not updated and because of that their
recover() method became "disabled".
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c
src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d
src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0
src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
Diff: https://reviews.apache.org/r/67820/diff/2/
Changes: https://reviews.apache.org/r/67820/diff/1-2/
Testing
-------
Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
Thanks,
Ilya Pronin
Re: Review Request 67820: Fixed recover() virtual method signature in
several isolators.
Posted by Benjamin Mahler <bm...@apache.org>.
> On July 5, 2018, 8:33 p.m., Benjamin Mahler wrote:
> > Also, is there a ticket? Did any releases ship with this broken? i.e. Do we need to backport this?
>
> Ilya Pronin wrote:
> No, should I create one? AFAIK the commit mentioned in the description was not included in any existing release. I checked branches `1.5.x` and `1.6.x` and didn't find it there.
Oh ok, I'm ok without one then. I mainly wanted one for tracking any affected releases / backporting.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205760
-----------------------------------------------------------
On July 5, 2018, 9:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
> std::vector in several places including the Isolator interface. However
> XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
> NetworkPortsIsolatorProcess were not updated and because of that their
> recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c
> src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d
> src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/2/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 67820: Fixed recover() virtual method signature in
several isolators.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On July 5, 2018, 1:33 p.m., Benjamin Mahler wrote:
> > Also, is there a ticket? Did any releases ship with this broken? i.e. Do we need to backport this?
No, should I create one? AFAIK the commit mentioned in the description was not included in any existing release. I checked branches `1.5.x` and `1.6.x` and didn't find it there.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205760
-----------------------------------------------------------
On July 5, 2018, 2:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
> std::vector in several places including the Isolator interface. However
> XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
> NetworkPortsIsolatorProcess were not updated and because of that their
> recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c
> src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d
> src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/2/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 67820: Fixed XfsDiskIsolatorProcess::recover()
signature.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205760
-----------------------------------------------------------
Also, is there a ticket? Did any releases ship with this broken? i.e. Do we need to backport this?
- Benjamin Mahler
On July 3, 2018, 9:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change r/67312 replaced std::list with std::vector in several places
> including the Isolator interface. However XfsDiskIsolatorProcess was not
> updated and because of that its recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/1/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 67820: Fixed recover() virtual method signature in
several isolators.
Posted by Ilya Pronin <ip...@twopensource.com>.
> On July 4, 2018, 3:42 a.m., James Peach wrote:
> > In the commit message, I'd prefer to refer to the abbreviated git SHA1 instead of the review ID. I just think that makes the changes slightly easier to track back.
> >
> > Can you please also update the `port_mapping` and `ports` isolators?
Fixed the commit message and expanded the patch to include `port_mapping` and `ports` isolators.
- Ilya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205716
-----------------------------------------------------------
On July 5, 2018, 2:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 5, 2018, 2:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Commit a52e5288ea94ec7d84f82c6c01c1ce3c7a3902db replaced std::list with
> std::vector in several places including the Isolator interface. However
> XfsDiskIsolatorProcess, PortMappingIsolatorProcess and
> NetworkPortsIsolatorProcess were not updated and because of that their
> recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 6ff3820de6af544c6ec92b0e76fd934715b87a96
> src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 3f51542ca27217c1063c19be481e8c47481f1e0c
> src/slave/containerizer/mesos/isolators/network/ports.hpp 8d467ceceae21d30318195785dce635d054d0f8d
> src/slave/containerizer/mesos/isolators/network/ports.cpp 82c14413cef0ac14ccfbc700f8f10a6c120c7fb0
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/2/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 67820: Fixed XfsDiskIsolatorProcess::recover()
signature.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67820/#review205716
-----------------------------------------------------------
In the commit message, I'd prefer to refer to the abbreviated git SHA1 instead of the review ID. I just think that makes the changes slightly easier to track back.
Can you please also update the `port_mapping` and `ports` isolators?
- James Peach
On July 3, 2018, 9:31 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67820/
> -----------------------------------------------------------
>
> (Updated July 3, 2018, 9:31 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Change r/67312 replaced std::list with std::vector in several places
> including the Isolator interface. However XfsDiskIsolatorProcess was not
> updated and because of that its recover() method became "disabled".
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/xfs/disk.hpp 9a5ca8bd60c61d65beed611a02dd26ed6a0a594b
> src/slave/containerizer/mesos/isolators/xfs/disk.cpp 362996b804be59dff631566d4c9db2d94233e0c9
>
>
> Diff: https://reviews.apache.org/r/67820/diff/1/
>
>
> Testing
> -------
>
> Built Mesos with `--enable-xfs-disk-isolator` and ran `sudo make check`. `ROOT_XFS_QuotaTest.NoCheckpointRecovery` test, that was broken because of the issue, passed.
>
>
> Thanks,
>
> Ilya Pronin
>
>