[jira] [Work logged] (LOG4J2-2947) LogBuilder should not have no-op default methods

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LOG4J2-2947?focusedWorklogId=848095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848095 ]

ASF GitHub Bot logged work on LOG4J2-2947:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Feb/23 15:03
            Start Date: 28/Feb/23 15:03
    Worklog Time Spent: 10m 
      Work Description: vy closed pull request #1051: LOG4J2-2947 - Make LogBuilder methods abstract
URL: https://github.com/apache/logging-log4j2/pull/1051




Issue Time Tracking
-------------------

            Worklog Id:     (was: 848095)
    Remaining Estimate: 0h
            Time Spent: 10m

> LogBuilder should not have no-op default methods
> ------------------------------------------------
>
>                 Key: LOG4J2-2947
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2947
>             Project: Log4j 2
>          Issue Type: Wish
>            Reporter: Marcono1234
>            Priority: Major
>             Fix For: 2.14.1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the methods of the interface {{org.apache.logging.log4j.LogBuilder}} are all default methods which are no-op.
> In my opinion this is not ideal because these no-op implementations should *only* exist for the {{LogBuilder.NOOP}}, or for any methods which are added in the future which not every logger supports.
> With the current situation it is easy to forget implementing one of the {{LogBuilder}} methods.
> If you choose to keep this {{LogBuilder}} behaviour, it would be good to at least document this so implementors of the interface are aware of it. Though this would then create confusion for the end-user because the {{LogBuilder}} returned by {{Logger}} is actually not no-op (which also shows that the {{LogBuilder}} methods should not be no-op by default in the first place).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)