You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2021/02/25 05:37:10 UTC
[GitHub] [groovy] kawatea opened a new pull request #1502: GROOVY-9954: Stop incrementing index after comments to avoid skipping…
kawatea opened a new pull request #1502:
URL: https://github.com/apache/groovy/pull/1502
https://issues.apache.org/jira/browse/GROOVY-9954
Stopped incrementing index in handleComment() and handleBashComment().
These are called in three places.
In decodeJsonObjectLax(), the index is incremented by the for-loop, but startIndexOfKey needs to be set to the next character after the comment.
In decodeValueInternal(), the index is incremented by the for-loop.
In decodeJsonArrayLax(), the index is not incremented by the do-while-loop, it needs to be manually incremented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 commented on pull request #1502: GROOVY-9954: Stop incrementing index after comments to avoid skipping…
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1502:
URL: https://github.com/apache/groovy/pull/1502#issuecomment-786790296
Merged. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] danielsun1106 merged pull request #1502: GROOVY-9954: Stop incrementing index after comments to avoid skipping…
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1502:
URL: https://github.com/apache/groovy/pull/1502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org