[GitHub] [spark] LuciferYang commented on a change in pull request #35412: [SPARK-38123][SQL] Unified use `DataType.catalogString` as `targetType` of `QueryExecutionErrors#castingCauseOverflowError`

[GitBox <gi...@apache.org>]

LuciferYang commented on a change in pull request #35412:
URL: https://github.com/apache/spark/pull/35412#discussion_r800333662



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/numerics.scala
##########
@@ -135,15 +135,15 @@ private[sql] object FloatExactNumeric extends FloatIsFractional {
     if (Math.floor(x) <= intUpperBound && Math.ceil(x) >= intLowerBound) {
       x.toInt
     } else {
-      throw QueryExecutionErrors.castingCauseOverflowError(x, "int")
+      throw QueryExecutionErrors.castingCauseOverflowError(x, IntegerType.catalogString)
     }
   }
 
   override def toLong(x: Float): Long = {
     if (Math.floor(x) <= longUpperBound && Math.ceil(x) >= longLowerBound) {
       x.toLong
     } else {
-      throw QueryExecutionErrors.castingCauseOverflowError(x, "int")

Review comment:
       this method is `toLong`, the `targetType` should be `long`, not `int`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org