You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/27 19:23:00 UTC
[jira] [Commented] (LOG4J2-1571) Example of extending Appenders
tries to extend from final class OutputStreamAppender
[ https://issues.apache.org/jira/browse/LOG4J2-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630934#comment-16630934 ]
ASF GitHub Bot commented on LOG4J2-1571:
----------------------------------------
GitHub user torbenmoeller opened a pull request:
https://github.com/apache/logging-log4j2/pull/217
[LOG4J2-1571] Fixed Appenders section in Extending Log4j
In the example the class inherited from a class declared as final. The example was changed, so that the class inherits from AbstractOutputStreamAppender, like other Appenders in the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/torbenmoeller/logging-log4j2 LOG4J2-1571
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 71969ada4ae4f60d436bdc8de74390479b6b9942
Author: Torben Möller <to...@...>
Date: 2018-09-27T19:14:41Z
[LOG4J2-1571] Fixed Appenders section in Extending Log4j
----
> Example of extending Appenders tries to extend from final class OutputStreamAppender
> ------------------------------------------------------------------------------------
>
> Key: LOG4J2-1571
> URL: https://issues.apache.org/jira/browse/LOG4J2-1571
> Project: Log4j 2
> Issue Type: Documentation
> Components: Documentation
> Affects Versions: 2.0
> Reporter: Adam A. Koch
> Priority: Minor
>
> On the page https://logging.apache.org/log4j/2.0/manual/extending.html#Appenders the code example StubAppender extends from OutputStreamAppender but that class is final and cannot be extended. A better example would be great!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)