[jira] [Work logged] (HIVE-24956) Add debug logs for time taken in the incremental event processing

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-24956?focusedWorklogId=594753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594753 ]

ASF GitHub Bot logged work on HIVE-24956:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/21 19:51
            Start Date: 11/May/21 19:51
    Worklog Time Spent: 10m 
      Work Description: pkumarsinha commented on a change in pull request #2135:
URL: https://github.com/apache/hive/pull/2135#discussion_r630468790



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws Exception {
     }
     this.childTasks.addAll(childTasks);
     createReplLoadCompleteAckTask();
+    LOG.info("REPL_INCREMENTAL_LOAD duration : {} ms", System.currentTimeMillis() - loadStartTime);

Review comment:
       Does schedule instance ID gets printed here? If not how do we related this message to the policy?

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java
##########
@@ -33,6 +33,7 @@
   private String dumpDir;
   private long numEvents;
   private long eventSeqNo;
+  private long currentEventTimestamp;

Review comment:
       Tracking the timing insider the logger may not be a great idea. Time taken for an event should be an input given to the logger from outside.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 594753)
    Time Spent: 20m  (was: 10m)

> Add debug logs for time taken in the incremental event processing
> -----------------------------------------------------------------
>
>                 Key: HIVE-24956
>                 URL: https://issues.apache.org/jira/browse/HIVE-24956
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Arko Sharma
>            Assignee: Arko Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)