[GitHub] vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance spark-submit for app management

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r253138246
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -95,20 +95,66 @@ private[spark] class SparkSubmit extends Logging {
   }
 
   /**
-   * Kill an existing submission using the REST protocol. Standalone and Mesos cluster mode only.
+   * Kill an existing submission.
+   * Standalone, Kubernetes and Mesos cluster mode only.
    */
   private def kill(args: SparkSubmitArguments): Unit = {
-    new RestSubmissionClient(args.master)
-      .killSubmission(args.submissionToKill)
+    if (args.master.startsWith("k8s://")) {
+      try {
+        val ops = Utils.classForName("org.apache.spark.deploy.k8s.submit.K8sSubmitOps$")
 
 Review comment:
   > Do you mean that I should use something like that? 
   
   Yes. That would make submission pluggable like the scheduler is, using a similar mechanism. Eventually I hope we can hide all of the details that SparkSubmit handles behind that interface...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org