You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Sutou Kouhei <ko...@clear-code.com> on 2022/06/02 23:32:35 UTC
[C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Hi,
We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
it's not maintained. Can we remove this?
Reasons:
1. I got build errors when I build it on master by
-DARROW_HIVESERVER2=ON. See
https://github.com/apache/arrow/pull/13292 for a fix of the
build errors.
We don't receive any bug report of it. It seems that
nobody uses our Hive adapter.
2. We don't have a CI job that enables our Hive adapter.
3. Apache Arrow Flight SQL or Apache Arrow Database
Connectivity may implement a feature to connect to Hive
in future.
Thanks,
--
kou
Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Posted by Sutou Kouhei <ko...@clear-code.com>.
Hi,
There is no objection. I'll remove
cpp/src/arrow/dbi/hiveserver2/:
https://issues.apache.org/jira/browse/ARROW-16832
Thanks,
--
kou
In <20...@clear-code.com>
"Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?" on Tue, 07 Jun 2022 14:56:34 +0900 (JST),
Sutou Kouhei <ko...@clear-code.com> wrote:
> Hi,
>
> Yes, I'll merge the fix and then remove
> cpp/src/arrow/dbi/hiveserver2.
>
>
> Thanks,
> --
> kou
>
> In <CA...@mail.gmail.com>
> "Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?" on Mon, 6 Jun 2022 13:25:41 -0400,
> Neal Richardson <ne...@gmail.com> wrote:
>
>> If you have fixes already for building it, perhaps merge those and then
>> remove it? That way, if we decided that we wanted to restore it (not that I
>> expect we would), we would be reverting to something that at least built
>> successfully.
>>
>> Neal
>>
>>
>> On Mon, Jun 6, 2022 at 1:04 PM Micah Kornfield <em...@gmail.com>
>> wrote:
>>
>>> +1
>>>
>>> On Mon, Jun 6, 2022 at 8:58 AM Antoine Pitrou <an...@python.org> wrote:
>>>
>>> >
>>> > +1 for removing it.
>>> >
>>> >
>>> > On Fri, 03 Jun 2022 08:32:35 +0900 (JST)
>>> > Sutou Kouhei <ko...@clear-code.com> wrote:
>>> > > Hi,
>>> > >
>>> > > We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
>>> > > it's not maintained. Can we remove this?
>>> > >
>>> > > Reasons:
>>> > >
>>> > > 1. I got build errors when I build it on master by
>>> > > -DARROW_HIVESERVER2=ON. See
>>> > > https://github.com/apache/arrow/pull/13292 for a fix of the
>>> > > build errors.
>>> > >
>>> > > We don't receive any bug report of it. It seems that
>>> > > nobody uses our Hive adapter.
>>> > >
>>> > > 2. We don't have a CI job that enables our Hive adapter.
>>> > >
>>> > > 3. Apache Arrow Flight SQL or Apache Arrow Database
>>> > > Connectivity may implement a feature to connect to Hive
>>> > > in future.
>>> > >
>>> > >
>>> > > Thanks,
>>> >
>>> >
>>> >
>>> >
>>>
Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Posted by Sutou Kouhei <ko...@clear-code.com>.
Hi,
Yes, I'll merge the fix and then remove
cpp/src/arrow/dbi/hiveserver2.
Thanks,
--
kou
In <CA...@mail.gmail.com>
"Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?" on Mon, 6 Jun 2022 13:25:41 -0400,
Neal Richardson <ne...@gmail.com> wrote:
> If you have fixes already for building it, perhaps merge those and then
> remove it? That way, if we decided that we wanted to restore it (not that I
> expect we would), we would be reverting to something that at least built
> successfully.
>
> Neal
>
>
> On Mon, Jun 6, 2022 at 1:04 PM Micah Kornfield <em...@gmail.com>
> wrote:
>
>> +1
>>
>> On Mon, Jun 6, 2022 at 8:58 AM Antoine Pitrou <an...@python.org> wrote:
>>
>> >
>> > +1 for removing it.
>> >
>> >
>> > On Fri, 03 Jun 2022 08:32:35 +0900 (JST)
>> > Sutou Kouhei <ko...@clear-code.com> wrote:
>> > > Hi,
>> > >
>> > > We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
>> > > it's not maintained. Can we remove this?
>> > >
>> > > Reasons:
>> > >
>> > > 1. I got build errors when I build it on master by
>> > > -DARROW_HIVESERVER2=ON. See
>> > > https://github.com/apache/arrow/pull/13292 for a fix of the
>> > > build errors.
>> > >
>> > > We don't receive any bug report of it. It seems that
>> > > nobody uses our Hive adapter.
>> > >
>> > > 2. We don't have a CI job that enables our Hive adapter.
>> > >
>> > > 3. Apache Arrow Flight SQL or Apache Arrow Database
>> > > Connectivity may implement a feature to connect to Hive
>> > > in future.
>> > >
>> > >
>> > > Thanks,
>> >
>> >
>> >
>> >
>>
Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Posted by Neal Richardson <ne...@gmail.com>.
If you have fixes already for building it, perhaps merge those and then
remove it? That way, if we decided that we wanted to restore it (not that I
expect we would), we would be reverting to something that at least built
successfully.
Neal
On Mon, Jun 6, 2022 at 1:04 PM Micah Kornfield <em...@gmail.com>
wrote:
> +1
>
> On Mon, Jun 6, 2022 at 8:58 AM Antoine Pitrou <an...@python.org> wrote:
>
> >
> > +1 for removing it.
> >
> >
> > On Fri, 03 Jun 2022 08:32:35 +0900 (JST)
> > Sutou Kouhei <ko...@clear-code.com> wrote:
> > > Hi,
> > >
> > > We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
> > > it's not maintained. Can we remove this?
> > >
> > > Reasons:
> > >
> > > 1. I got build errors when I build it on master by
> > > -DARROW_HIVESERVER2=ON. See
> > > https://github.com/apache/arrow/pull/13292 for a fix of the
> > > build errors.
> > >
> > > We don't receive any bug report of it. It seems that
> > > nobody uses our Hive adapter.
> > >
> > > 2. We don't have a CI job that enables our Hive adapter.
> > >
> > > 3. Apache Arrow Flight SQL or Apache Arrow Database
> > > Connectivity may implement a feature to connect to Hive
> > > in future.
> > >
> > >
> > > Thanks,
> >
> >
> >
> >
>
Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Posted by Micah Kornfield <em...@gmail.com>.
+1
On Mon, Jun 6, 2022 at 8:58 AM Antoine Pitrou <an...@python.org> wrote:
>
> +1 for removing it.
>
>
> On Fri, 03 Jun 2022 08:32:35 +0900 (JST)
> Sutou Kouhei <ko...@clear-code.com> wrote:
> > Hi,
> >
> > We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
> > it's not maintained. Can we remove this?
> >
> > Reasons:
> >
> > 1. I got build errors when I build it on master by
> > -DARROW_HIVESERVER2=ON. See
> > https://github.com/apache/arrow/pull/13292 for a fix of the
> > build errors.
> >
> > We don't receive any bug report of it. It seems that
> > nobody uses our Hive adapter.
> >
> > 2. We don't have a CI job that enables our Hive adapter.
> >
> > 3. Apache Arrow Flight SQL or Apache Arrow Database
> > Connectivity may implement a feature to connect to Hive
> > in future.
> >
> >
> > Thanks,
>
>
>
>
Re: [C++] Can we remove cpp/src/arrow/dbi/hiveserver2?
Posted by Antoine Pitrou <an...@python.org>.
+1 for removing it.
On Fri, 03 Jun 2022 08:32:35 +0900 (JST)
Sutou Kouhei <ko...@clear-code.com> wrote:
> Hi,
>
> We have Hive adapter in cpp/src/arrow/dbi/hiveserver2 but
> it's not maintained. Can we remove this?
>
> Reasons:
>
> 1. I got build errors when I build it on master by
> -DARROW_HIVESERVER2=ON. See
> https://github.com/apache/arrow/pull/13292 for a fix of the
> build errors.
>
> We don't receive any bug report of it. It seems that
> nobody uses our Hive adapter.
>
> 2. We don't have a CI job that enables our Hive adapter.
>
> 3. Apache Arrow Flight SQL or Apache Arrow Database
> Connectivity may implement a feature to connect to Hive
> in future.
>
>
> Thanks,