You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/24 14:06:18 UTC

[GitHub] [flink] wuchong edited a comment on pull request #14735: [FLINK-20961][table-planner-blink] Fix NPE when no assigned timestamp defined

wuchong edited a comment on pull request #14735:
URL: https://github.com/apache/flink/pull/14735#issuecomment-766353650


   Oops, `MatchRecognizeITCase.testWindowedGroupingAppliedToMatchRecognize` is still failed, because `org.apache.flink.cep.time.TimeContext#timestamp()` returns primitive type `long`, and `long` can't be compared with `null`. 
   
   I think we either we generate a special code for `MATCH_ROWTIME` in `MatchCodeGenerator#visitCall`, either faillback your previous approach by introducing a temporary `Long` variable. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org