[GitHub] [opennlp] kinow commented on a diff in pull request #456: OPENNLP-1410 Enhance JavaDoc in opennlp.tools.namefind package

[GitBox <gi...@apache.org>]

kinow commented on code in PR #456:
URL: https://github.com/apache/opennlp/pull/456#discussion_r1045223051


##########
opennlp-tools/src/main/java/opennlp/tools/namefind/BioCodec.java:
##########
@@ -26,23 +26,39 @@
 import opennlp.tools.util.SequenceCodec;
 import opennlp.tools.util.Span;
 
+/**
+ * The default {@link SequenceCodec} implementation according to the {@code BIO} scheme:
+ * <ul>
+ *   <li>B: 'beginning' of a NE)</li>
+ *   <li>I: 'inside', the word is inside a NE</li>
+ *   <li>O: 'outside', the word is a regular word outside a NE)</li>

Review Comment:
   Same here?



##########
opennlp-tools/src/main/java/opennlp/tools/namefind/BilouCodec.java:
##########
@@ -27,6 +27,23 @@
 import opennlp.tools.util.SequenceValidator;
 import opennlp.tools.util.Span;
 
+/**
+ * The default {@link SequenceCodec} implementation according to the {@code BILOU} scheme.
+ * <ul>
+ *   <li>B: 'beginning' of a NE)</li>
+ *   <li>I: 'inside', the word is inside a NE)</li>

Review Comment:
   I think the `NE)` has an extra `)` in these two cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org