[GitHub] [spark] srowen commented on a change in pull request #31484: [SPARK-34374][SQL][DSTREAM] Use standard methods to extract keys or values from a Map

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #31484:
URL: https://github.com/apache/spark/pull/31484#discussion_r571735255



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
##########
@@ -406,7 +406,7 @@ object PreprocessTableInsertion extends Rule[LogicalPlan] {
       catalogTable.get.tracksPartitionsInCatalog
     if (partitionsTrackedByCatalog && normalizedPartSpec.nonEmpty) {
       // empty partition column value
-      if (normalizedPartSpec.map(_._2)
+      if (normalizedPartSpec.values
           .filter(_.isDefined).map(_.get).exists(v => v != null && v.isEmpty)) {

Review comment:
       How about just .flatten instead of the filter and map? I think that's another simplification that's valid.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org