[GitHub] [spark] HeartSaVioR commented on pull request #33977: [SPARK-36737][BUILD][CORE][SQL][SS] Upgrade Apache commons-io to 2.11.0 and revert change of SPARK-36456

[GitBox <gi...@apache.org>]

HeartSaVioR commented on pull request #33977:
URL: https://github.com/apache/spark/pull/33977#issuecomment-918666240


   I can't say for every places we use, but if I understand correctly, in HDFSBackedStateStoreProvider, we simplified the logic via allowing to close stream twice (with suppression of log message), given the fact that IOException happens with temporary file and we don't hurt anything.
   
   SPARK-36456 seemed to actually deal with deprecation warning message, which means the behavioral difference between IOUtils.closeQuietly and JavaUtils.closeQuietly is an unintentional change. If we identify somewhere we use IOUtils.closeQuietly which is better to log swallowed IOException, we should have a separate PR to change there to JavaUtils.closeQuietly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org