You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by iraghumitra <gi...@git.apache.org> on 2017/10/30 12:56:02 UTC
[GitHub] metron pull request #819: METRON-1267: Alerts UI returns a 404 when refreshi...
GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/819
METRON-1267: Alerts UI returns a 404 when refreshing the alerts-list page
Fixed the 404 error when refreshing alerts-ui(added the missing base-dir path).
Looks like the last fix didn't completely fix the issue still refresh on alerts-ui in full dev throws 404 with the following error in /var/log/metron/metron-alerts-ui.log
TypeError: path must be absolute or specify root to res.sendFile
at ServerResponse.sendFile (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/response.js:410:11)
at /usr/metron/0.4.2/web/expressjs/alerts-server.js:71:7
at Layer.handle [as handle_request] (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/layer.js:95:5)
at next (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/route.js:137:13)
at Route.dispatch (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/route.js:112:3)
at Layer.handle [as handle_request] (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/layer.js:95:5)
at /usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/index.js:281:22
at param (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/index.js:354:14)
at param (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/index.js:365:14)
at Function.process_params (/usr/metron/0.4.2/web/expressjs/node_modules/express/lib/router/index.js:410:3)`
## Testing
- Launch alerts-ui from full dev and refresh the page, we get a 404 on the page
- Copy the file (or copy the fix) to $METRON_HOME/web/expressjs/alerts-server.js on full dev
- Restart Alerts UI from Ambari
- Launch alerts-ui from full dev and refresh the page it should not throws 404
## Contributor Comments
[Please place any comments here. A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iraghumitra/incubator-metron METRON-1267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/819.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #819
----
commit a82e03d3aa4b98522f480a1b16966049f13de655
Author: iraghumitra <ra...@gmail.com>
Date: 2017-10-30T12:42:30Z
Fixed the 404 error when refreshing alerts-ui, added the missing base-dir path
----
---
[GitHub] metron issue #819: METRON-1267: Alerts UI returns a 404 when refreshing the ...
Posted by merrimanr <gi...@git.apache.org>.
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/819
Tested this in full dev and it resolved the issue. Thanks for fixing this. +1
---
[GitHub] metron pull request #819: METRON-1267: Alerts UI returns a 404 when refreshi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/819
---