[native-toolchain-CR] IMPALA-12100: Set REGISTER INSTALL PREFIX=Off for gflags build

["Joe McDonnell (Code Review)" <ge...@cloudera.org>]

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19798

to look at the new patch set (#2).

Change subject: IMPALA-12100: Set REGISTER_INSTALL_PREFIX=Off for gflags build
......................................................................

IMPALA-12100: Set REGISTER_INSTALL_PREFIX=Off for gflags build

When building the native-toolchain outside of Docker,
the Kudu build fails with link errors related to
glog's logging.cc having an undefined reference to
FlagRegisterer. This is because Kudu's glog build is
picking up Impala's gflags, which has a different signature
for FlagRegisterer.

It picks up Impala's gflags because gflags registers itself
in the user's home directory under the .cmake directory. Glog
must pick that up somehow. This is controlled by the
REGISTER_INSTALL_PREFIX CMake option for gflags. This sets
REGISTER_INSTALL_PREFIX=Off to avoid this interaction.

This also cleans up gflags' build.sh to remore the old non-CMake
code.

Testing:
 - Building the toolchain outside of Docker passed on x86_64
   with this change

Change-Id: I682ce40622f4bbad0c412de29006a3a9b4ae4765
---
M source/gflags/build.sh
1 file changed, 4 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/98/19798/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I682ce40622f4bbad0c412de29006a3a9b4ae4765
Gerrit-Change-Number: 19798
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>