[GitHub] [kyuubi] yaooqinn commented on a diff in pull request #4246: [KYUUBI #4245][SPARK] Support UserDefinedType for Spark 3.2 and above

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #4246:
URL: https://github.com/apache/kyuubi/pull/4246#discussion_r1100929048


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala:
##########
@@ -64,7 +82,7 @@ object SchemaHelper {
     case _: ArrayType => TTypeId.ARRAY_TYPE
     case _: MapType => TTypeId.MAP_TYPE
     case _: StructType => TTypeId.STRUCT_TYPE
-    // TODO: it is private now, case udt: UserDefinedType => TTypeId.USER_DEFINED_TYPE
+    case dt: DateType if isUserDefinedType(dt) => TTypeId.USER_DEFINED_TYPE

Review Comment:
   Is case udt: UserDefinedType => TTypeId.USER_DEFINED_TYPE good to go？
   
   BTW, you shall not use `DateType` but `DataType` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org