You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/01 03:17:00 UTC

[jira] [Work logged] (LANG-1634) ObjectUtils - apply Consumer with non-null value

     [ https://issues.apache.org/jira/browse/LANG-1634?focusedWorklogId=529925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-529925 ]

ASF GitHub Bot logged work on LANG-1634:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jan/21 03:16
            Start Date: 01/Jan/21 03:16
    Worklog Time Spent: 10m 
      Work Description: coveralls edited a comment on pull request #684:
URL: https://github.com/apache/commons-lang/pull/684#issuecomment-751870250


   
   [![Coverage Status](https://coveralls.io/builds/36026901/badge)](https://coveralls.io/builds/36026901)
   
   Coverage decreased (-0.003%) to 95.01% when pulling **6ae1ac0e859d7cadff14434bbdfe4c865c17ad86 on bindul:LANG-1634_ObjectUtils-applyIfNonNull** into **f5c86f6d4e8d9023f9e023fb1cd09ef47c8fd1cf on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 529925)
    Time Spent: 2h 20m  (was: 2h 10m)

> ObjectUtils - apply Consumer with non-null value
> ------------------------------------------------
>
>                 Key: LANG-1634
>                 URL: https://issues.apache.org/jira/browse/LANG-1634
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Bindul Bhowmik
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> There are multiple places in code where we have to check if a value is {{null}} before using it in a setter or other method, like:
> {code:java}
> if (valueX != null) {
> 	bean.setValue(valueX);
> 	someObject.compute(valueX, "bar");
> }
> {code}
> This enhancement request is to add a couple of methods in {{ObjectUtils}} to wrap this logic,  like the following:
> {code:java}
> public static <T> void applyIfNonNull(final Consumer<T> consumer, final T object)
> public static <T> void applyFirstNonNull(final Consumer<T> consumer, final T... objects)
> {code}
> With this the two statements above could be used as:
> {code:java}
> ObjectUtils.applyIfNonNull(bean::setValue, valueX);
> ObjectUtils.appyIfNonNull(v -> someObject.compute(v, "bar"), valueX);
> {code}
> The benefit of this should increase with more such null checks we need in the code that can be replaced by single statements.
> Pull request forthcoming.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)