[GitHub] [helix] narendly commented on a change in pull request #671: Add ZooKeeperAccessor to helix-rest

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #671: Add ZooKeeperAccessor to helix-rest
URL: https://github.com/apache/helix/pull/671#discussion_r365982586
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
 ##########
 @@ -55,8 +56,8 @@
   public Response getPropertyByPath(@PathParam("clusterId") String clusterId,
       @PathParam("path") String path) {
     path = "/" + path;
-    if (!isPathValid(path)) {
-      LOG.info("The propertyStore path {} is invalid for cluster {}", path, clusterId);
+    if (!ZooKeeperAccessor.isPathValid(path)) {
+      LOG.error("The propertyStore path {} is invalid for cluster {}", path, clusterId);
 
 Review comment:
   That makes sense. This is not the error from the server's perspective. Will change it back to info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org