You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2022/03/01 23:32:18 UTC
[GitHub] [madlib] orhankislal opened a new pull request #577: GLM-multinom: Use non-temp tables in GroupIterationController
orhankislal opened a new pull request #577:
URL: https://github.com/apache/madlib/pull/577
There is a potential issue with pg_temp not cleaning up correctly in
the case of a failure in GLM and multinom. This commit changes the
default value to create the temp table used for state aggregation to
avoid the temporary tables.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. Refer to this link for contribution guidelines https://cwiki.apache.org/confluence/display/MADLIB/Contribution+Guidelines
2. Please Provide the Module Name, a JIRA Number and a short description about your changes.
-->
- [ ] Add the module name, JIRA# to PR/commit and description.
- [ ] Add tests for the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] khannaekta commented on a change in pull request #577: GLM-multinom: Use non-temp tables in GroupIterationController
Posted by GitBox <gi...@apache.org>.
khannaekta commented on a change in pull request #577:
URL: https://github.com/apache/madlib/pull/577#discussion_r818018152
##########
File path: src/ports/postgres/modules/glm/glm.py_in
##########
@@ -350,7 +351,7 @@ def __glm_compute(schema_madlib, tbl_source, tbl_output, col_dep_var, col_ind_va
**args))
# clean up
- plpy.execute("""DROP TABLE IF EXISTS pg_temp.{rel_state} """.format(**args))
Review comment:
Do we call this only once? Since this isn't defined as a temp table, we probably would want to reclaim the space of table, similar to the DL module using `dev_opt_unsafe_truncate_in_subtransaction` guc. (https://github.com/apache/madlib/blob/master/src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in#L985-L988)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] orhankislal closed pull request #577: GLM-multinom: Use non-temp tables in GroupIterationController
Posted by GitBox <gi...@apache.org>.
orhankislal closed pull request #577:
URL: https://github.com/apache/madlib/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [madlib] orhankislal commented on a change in pull request #577: GLM-multinom: Use non-temp tables in GroupIterationController
Posted by GitBox <gi...@apache.org>.
orhankislal commented on a change in pull request #577:
URL: https://github.com/apache/madlib/pull/577#discussion_r818152419
##########
File path: src/ports/postgres/modules/glm/glm.py_in
##########
@@ -350,7 +351,7 @@ def __glm_compute(schema_madlib, tbl_source, tbl_output, col_dep_var, col_ind_va
**args))
# clean up
- plpy.execute("""DROP TABLE IF EXISTS pg_temp.{rel_state} """.format(**args))
Review comment:
Yes this is called only once at the end of the training.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@madlib.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org