You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Rebriy (JIRA)" <ji...@apache.org> on 2007/12/28 12:00:43 UTC

[jira] Commented: (HARMONY-4703) [drlvm][thread] minor hythread_safe_point_other improvement

    [ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554673 ] 

Pavel Rebriy commented on HARMONY-4703:
---------------------------------------

The bug is fixed after commit of revision 606926 (HARMONY-4937).

> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
>                 Key: HARMONY-4703
>                 URL: https://issues.apache.org/jira/browse/HARMONY-4703
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Aleksey Shipilev
>            Priority: Minor
>         Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
>     thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
>     thread_safe_point_impl(thread);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.