You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/03 16:51:34 UTC

[GitHub] [zookeeper] belugabehr opened a new pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

belugabehr opened a new pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] belugabehr commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-721342718


   @ctubbsii Please review and merge?  Thanks! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-722312993


   Please go ahead. thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg closed pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
nkalmar commented on a change in pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#discussion_r428207056



##########
File path: pom.xml
##########
@@ -421,6 +421,7 @@
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
     <dependency.locations.enabled>false</dependency.locations.enabled>
+    <surefire.version>2.22.1</surefire.version>

Review comment:
       Why did you add this property?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] belugabehr closed pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
belugabehr closed pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] belugabehr commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-721836701


   @eolivelli  Ping :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-721367445


   I will merge tomorrow.
   Feel free to ping me if you do not see activity


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] belugabehr commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-721343185


   @nkalmar Can you please review once more? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-721351869


   > @ctubbsii Please review and merge? Thanks! :)
   
   I can review, but you haven't changed it since my last review. I'm not a committer, so I can't help you merge. Sorry.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-722344848


   > Please go ahead. thanks
   
   Okay; now in `master`.  Thank you, @belugabehr!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] nkalmar commented on a change in pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
nkalmar commented on a change in pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#discussion_r428209865



##########
File path: pom.xml
##########
@@ -421,6 +421,7 @@
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
     <dependency.locations.enabled>false</dependency.locations.enabled>
+    <surefire.version>2.22.1</surefire.version>

Review comment:
       NVM, I see it's 2.22.0 in parent apache pom.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ctubbsii commented on a change in pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#discussion_r426968655



##########
File path: pom.xml
##########
@@ -679,32 +677,26 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-assembly-plugin</artifactId>
-          <version>3.1.0</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-release-plugin</artifactId>
-          <version>3.0.0-M1</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-scm-plugin</artifactId>
-          <version>1.11.2</version>

Review comment:
       1.11.2 is newer than the one set in the parent pom, so it should stay.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] belugabehr commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-630806235


   @ctubbsii Great catch.  Thanks.  Change reverted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] nkalmar commented on pull request #1354: ZOOKEEPER-3833: Do Not Override Plugin Versions from Apache Parent POM

Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1354:
URL: https://github.com/apache/zookeeper/pull/1354#issuecomment-631634918


   Out of curiosity checked why scm-plugin is newer, simply because it was added not long ago by ZOOKEEPER-3635, but yeah, let's not step backward with versions. Probably the explicit version can be removed in a feature PR :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org