You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2019/04/17 18:30:54 UTC
GEODE-6662 for 1.9.0
I'd like to include the fix for this memory leak that Darrel found.
It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
Re: GEODE-6662 for 1.9.0
Posted by Bruce Schuchardt <bs...@pivotal.io>.
This leak could cause a long running server to run out of direct-buffer
memory, especially if conserve-sockets=false.
On 4/17/19 11:45 AM, Udo Kohlmeyer wrote:
> Unless this is a critical issue I'd vote -1 for including this.
>
> The process to release 1.9 has already been started and should be
> closed to anything other than critical CVE's.
>
> --Udo
>
> On 4/17/19 11:30, Bruce Schuchardt wrote:
>> I'd like to include the fix for this memory leak that Darrel found.
>> It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
>>
Re: GEODE-6662 for 1.9.0
Posted by Bruce Schuchardt <bs...@pivotal.io>.
I've cherry-picked the fix into release/1.9.0
On 4/17/19 1:22 PM, Lynn Hughes-Godfrey wrote:
> +1 to Bruce & Anthony's suggestion to fix it. GemFire servers are meant to
> be long running processes.
>
> On Wed, Apr 17, 2019 at 12:09 PM Jacob Barrett <jb...@pivotal.io> wrote:
>
>> If it Leakes on object overt the life of the application, no biggy. If it
>> leaks an object frequently, say every time you call get, then fixxy.
>>
>> -Jake
>>
>>> On Apr 17, 2019, at 12:05 PM, Anthony Baker <ab...@pivotal.io> wrote:
>>>
>>> If a geode process leaks memory, I think that’s a critical issue.
>>>
>>> Anthony
>>>
>>>
>>>> On Apr 17, 2019, at 11:45 AM, Udo Kohlmeyer <ud...@apache.org> wrote:
>>>>
>>>> Unless this is a critical issue I'd vote -1 for including this.
>>>>
>>>> The process to release 1.9 has already been started and should be
>> closed to anything other than critical CVE's.
>>>> --Udo
>>>>
>>>> On 4/17/19 11:30, Bruce Schuchardt wrote:
>>>>> I'd like to include the fix for this memory leak that Darrel found.
>> It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
>>
Re: GEODE-6662 for 1.9.0
Posted by Lynn Hughes-Godfrey <lh...@pivotal.io>.
+1 to Bruce & Anthony's suggestion to fix it. GemFire servers are meant to
be long running processes.
On Wed, Apr 17, 2019 at 12:09 PM Jacob Barrett <jb...@pivotal.io> wrote:
> If it Leakes on object overt the life of the application, no biggy. If it
> leaks an object frequently, say every time you call get, then fixxy.
>
> -Jake
>
> > On Apr 17, 2019, at 12:05 PM, Anthony Baker <ab...@pivotal.io> wrote:
> >
> > If a geode process leaks memory, I think that’s a critical issue.
> >
> > Anthony
> >
> >
> >> On Apr 17, 2019, at 11:45 AM, Udo Kohlmeyer <ud...@apache.org> wrote:
> >>
> >> Unless this is a critical issue I'd vote -1 for including this.
> >>
> >> The process to release 1.9 has already been started and should be
> closed to anything other than critical CVE's.
> >>
> >> --Udo
> >>
> >> On 4/17/19 11:30, Bruce Schuchardt wrote:
> >>> I'd like to include the fix for this memory leak that Darrel found.
> It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
> >>>
> >
>
>
Re: GEODE-6662 for 1.9.0
Posted by Jacob Barrett <jb...@pivotal.io>.
If it Leakes on object overt the life of the application, no biggy. If it leaks an object frequently, say every time you call get, then fixxy.
-Jake
> On Apr 17, 2019, at 12:05 PM, Anthony Baker <ab...@pivotal.io> wrote:
>
> If a geode process leaks memory, I think that’s a critical issue.
>
> Anthony
>
>
>> On Apr 17, 2019, at 11:45 AM, Udo Kohlmeyer <ud...@apache.org> wrote:
>>
>> Unless this is a critical issue I'd vote -1 for including this.
>>
>> The process to release 1.9 has already been started and should be closed to anything other than critical CVE's.
>>
>> --Udo
>>
>> On 4/17/19 11:30, Bruce Schuchardt wrote:
>>> I'd like to include the fix for this memory leak that Darrel found. It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
>>>
>
Re: GEODE-6662 for 1.9.0
Posted by Anthony Baker <ab...@pivotal.io>.
If a geode process leaks memory, I think that’s a critical issue.
Anthony
> On Apr 17, 2019, at 11:45 AM, Udo Kohlmeyer <ud...@apache.org> wrote:
>
> Unless this is a critical issue I'd vote -1 for including this.
>
> The process to release 1.9 has already been started and should be closed to anything other than critical CVE's.
>
> --Udo
>
> On 4/17/19 11:30, Bruce Schuchardt wrote:
>> I'd like to include the fix for this memory leak that Darrel found. It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
>>
Re: GEODE-6662 for 1.9.0
Posted by Udo Kohlmeyer <ud...@apache.org>.
Unless this is a critical issue I'd vote -1 for including this.
The process to release 1.9 has already been started and should be closed
to anything other than critical CVE's.
--Udo
On 4/17/19 11:30, Bruce Schuchardt wrote:
> I'd like to include the fix for this memory leak that Darrel found.
> It's new in 1.9 and the fix is pretty simple - I'm putting up a PR now.
>