You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tr...@apache.org on 2018/07/18 07:51:29 UTC
[3/3] flink git commit: [hotfix] Harden
JarUploadHandlerTest#testUploadJar
[hotfix] Harden JarUploadHandlerTest#testUploadJar
Use lastIndexOf("_") instead of indexOf("_") in order to find the file name part
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/5a89b9aa
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/5a89b9aa
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/5a89b9aa
Branch: refs/heads/master
Commit: 5a89b9aa4085d005312a01ff758ba960424fc01d
Parents: 4095a31
Author: Till Rohrmann <tr...@apache.org>
Authored: Wed Jul 18 09:48:49 2018 +0200
Committer: Till Rohrmann <tr...@apache.org>
Committed: Wed Jul 18 09:50:09 2018 +0200
----------------------------------------------------------------------
.../flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/5a89b9aa/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java b/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java
index 164171d..648e7fc 100644
--- a/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java
+++ b/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarUploadHandlerTest.java
@@ -106,7 +106,7 @@ public class JarUploadHandlerTest extends TestLogger {
assertThat(jarUploadResponseBody.getStatus(), equalTo(JarUploadResponseBody.UploadStatus.success));
final String returnedFileNameWithUUID = jarUploadResponseBody.getFilename();
assertThat(returnedFileNameWithUUID, containsString("_"));
- final String returnedFileName = returnedFileNameWithUUID.substring(returnedFileNameWithUUID.indexOf("_") + 1);
+ final String returnedFileName = returnedFileNameWithUUID.substring(returnedFileNameWithUUID.lastIndexOf("_") + 1);
assertThat(returnedFileName, equalTo(uploadedFile.getFileName().toString()));
}