You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/05 18:00:41 UTC
[GitHub] [skywalking-python] tom-pytel opened a new pull request #145: Cleaned up Tags
tom-pytel opened a new pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145
This is for merging after #143 (it does include all the changes from that PR which has already been approved but not yet merged). This cleans up the Tag mechanism as follows:
* Each Tag is not its own individual class, which allows 'overridable' to be property of the tag and not specified at tag instantiate.
* Should be more performant.
* Key changes `url` -> `http.url` and `status.code` -> `http.status.code` to match Node agent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] sonatype-lift[bot] commented on a change in pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683687283
##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +57,7 @@ def __init__(
self.layer = layer or Layer.Unknown # type: Layer
self.inherit = Component.Unknown # type: Component
- self.tags = [] # type: List[Tag]
+ self.tags = defaultdict(list) # type: Dict[str, Union[Tag, List[Tag]]]
Review comment:
*Incompatible attribute type:* Attribute `tags` declared in class `Span` has type `Dict[str, Union[List[Tag], Tag]]` but is used as type `typing.DefaultDict[Variable[collections._KT], List[Variable[_T]]]`.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#issuecomment-894786291
> Key @kezhenxu94, I am blocking on this a little, can I merge an move on?
Oops, sorry forgot this. 🤦🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#issuecomment-893817618
Or merge this first then update #144...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#issuecomment-894786113
Key @kezhenxu94, I am blocking on this a little, can I merge an move on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] sonatype-lift[bot] commented on a change in pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683693254
##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +57,7 @@ def __init__(
self.layer = layer or Layer.Unknown # type: Layer
self.inherit = Component.Unknown # type: Component
- self.tags = [] # type: List[Tag]
+ self.tags = defaultdict(list) # type: DefaultDict[str, Union[Tag, List[Tag]]]
Review comment:
*Incompatible attribute type:* Attribute `tags` declared in class `Span` has type `DefaultDict[str, Union[List[Tag], Tag]]` but is used as type `DefaultDict[Variable[collections._KT], List[Variable[_T]]]`.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] sonatype-lift[bot] commented on a change in pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683681543
##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +58,7 @@ def __init__(
self.layer = layer or Layer.Unknown # type: Layer
self.inherit = Component.Unknown # type: Component
- self.tags = [] # type: List[Tag]
+ self.tags = defaultdict(list) # type: Dict[str, Union(Tag, List[Tag])]
Review comment:
*Invalid type:* Expression `Dict[(str, Union(skywalking.trace.tags.Tag, typing.List[skywalking.trace.tags.Tag]))]` is not a valid type.
(at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#issuecomment-893675665
Do not merge until #144 is merged and I update this for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel commented on a change in pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
tom-pytel commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683693983
##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +57,7 @@ def __init__(
self.layer = layer or Layer.Unknown # type: Layer
self.inherit = Component.Unknown # type: Component
- self.tags = [] # type: List[Tag]
+ self.tags = defaultdict(list) # type: DefaultDict[str, Union[Tag, List[Tag]]]
Review comment:
ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] tom-pytel merged pull request #145: Cleaned up Tags
Posted by GitBox <gi...@apache.org>.
tom-pytel merged pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org